Skip to content

Sending API key using email template - #1013

Closed
ziadhany wants to merge 1 commit into
aboutcode-org:mainfrom
ziadhany:email-template
Closed

ziadhany wants to merge 1 commit into
aboutcode-org:mainfrom
ziadhany:email-template

Conversation

@ziadhany

Copy link
Copy Markdown
Collaborator

#1003
Signed-off-by: ziadhany ziadhany2016@gmail.com

Sending API key using email template

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany

ziadhany commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator Author

this is how the email look like on all devices
image
image
image

@TG1999

TG1999 commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

@ziadhany please provide screenshots of how this email looked previously without your changes and with your changes

@ziadhany

Copy link
Copy Markdown
Collaborator Author

@ziadhany please provide screenshots of how this email looked previously without your changes and with your changes

image

@ziadhany

ziadhany commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator Author

@ziadhany please provide screenshots of how this email looked previously without your changes and with your changes

This is without my changes

image

@pombredanne

Copy link
Copy Markdown
Member

It really looks good, but I am still pondering whether a plain text would not best. I am always suspicious of HTML email with links.

@ziadhany

ziadhany commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator Author

It really looks good, but I am still pondering whether a plain text would not best. I am always suspicious of HTML email with links.

I think we can send both html and text/plain ( if you don't mind ) and let the user choose what he wants

@ziadhany ziadhany closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants