Migrate kaybee importer #1011 - #1021
Closed
TG1999 wants to merge 4 commits into
Closed
Conversation
TG1999
force-pushed
the
migrate/kaybee
branch
from
November 30, 2022 12:19
dd85641 to
8ac8250
Compare
TG1999
marked this pull request as draft
November 30, 2022 12:20
TG1999
force-pushed
the
migrate/kaybee
branch
from
December 8, 2022 11:19
8ac8250 to
a761b53
Compare
TG1999
marked this pull request as ready for review
December 8, 2022 11:19
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
migrate/kaybee
branch
from
December 9, 2022 13:29
a761b53 to
29fd3fd
Compare
pombredanne
requested changes
Dec 24, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! Iwould like to make sure we have a proper way to identify a fix commit reference
| for commit in fix["commits"]: | ||
| for fix in data.get("fixes") or []: | ||
| for commit in fix.get("commits") or []: | ||
| references.append(Reference(url=f"{commit['repository']}/{commit['id']}")) |
Member
There was a problem hiding this comment.
Would there be a way to state that this is fix commit explicitly?
TG1999
marked this pull request as draft
December 26, 2022 11:20
Contributor
Author
|
Closing this PR for now, will re-open once models are open for storing commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.