Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions vulnerabilities/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,6 @@ class Meta:
fields = ["url", "purl", "is_vulnerable"]


class VulnSerializerRefsAndSummary(serializers.HyperlinkedModelSerializer):
"""
Lookup vulnerabilities references by aliases (such as a CVE).
"""

fixed_packages = MinimalPackageSerializer(
many=True, source="filtered_fixed_packages", read_only=True
)

references = VulnerabilityReferenceSerializer(many=True, source="vulnerabilityreference_set")

class Meta:
model = Vulnerability
fields = ["url", "vulnerability_id", "summary", "references", "fixed_packages"]


class MinimalVulnerabilitySerializer(serializers.HyperlinkedModelSerializer):
"""
Lookup vulnerabilities by aliases (such as a CVE).
Expand All @@ -89,6 +73,29 @@ class Meta:
fields = ["alias"]


class VulnSerializerRefsAndSummary(serializers.HyperlinkedModelSerializer):
"""
Lookup vulnerabilities references by aliases (such as a CVE).
"""

def to_representation(self, instance):
data = super().to_representation(instance)
aliases = [alias["alias"] for alias in data["aliases"]]
data["aliases"] = aliases
return data

fixed_packages = MinimalPackageSerializer(
many=True, source="filtered_fixed_packages", read_only=True
)

references = VulnerabilityReferenceSerializer(many=True, source="vulnerabilityreference_set")
aliases = AliasSerializer(many=True, source="alias")

class Meta:
model = Vulnerability
fields = ["url", "vulnerability_id", "summary", "references", "fixed_packages", "aliases"]


class VulnerabilitySerializer(serializers.HyperlinkedModelSerializer):

fixed_packages = MinimalPackageSerializer(
Expand Down
8 changes: 8 additions & 0 deletions vulnerabilities/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ def setUp(self):
vuln1 = Vulnerability.objects.create(
summary="test-vuln1",
)
Alias.objects.create(alias="CVE-2019-1234", vulnerability=vuln1)
Alias.objects.create(alias="GMS-1234-4321", vulnerability=vuln1)
Alias.objects.create(alias="CVE-2029-1234", vulnerability=vuln)
self.vuln1 = vuln1
PackageRelatedVulnerability.objects.create(
package=self.package,
Expand Down Expand Up @@ -340,6 +343,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
"summary": "test-vuln1",
"references": [],
"fixed_packages": [],
"aliases": ["CVE-2019-1234", "GMS-1234-4321"],
}
],
"fixing_vulnerabilities": [
Expand All @@ -355,6 +359,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
"is_vulnerable": True,
}
],
"aliases": ["CVE-2029-1234"],
},
],
"unresolved_vulnerabilities": [
Expand All @@ -364,6 +369,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
"summary": "test-vuln1",
"references": [],
"fixed_packages": [],
"aliases": ["CVE-2019-1234", "GMS-1234-4321"],
}
],
}
Expand Down Expand Up @@ -392,6 +398,7 @@ def test_api_with_single_vulnerability_and_vulnerable_package(self):
"is_vulnerable": True,
}
],
"aliases": ["CVE-2029-1234"],
}
],
"fixing_vulnerabilities": [],
Expand All @@ -408,6 +415,7 @@ def test_api_with_single_vulnerability_and_vulnerable_package(self):
"is_vulnerable": True,
}
],
"aliases": ["CVE-2029-1234"],
}
],
}
Expand Down