Remove weaknesses from view which are not in DB - #1256
Merged
Conversation
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
fix_cwe_view_problem
branch
from
August 2, 2023 19:01
50f82a3 to
3dab859
Compare
tdruez
requested changes
Aug 3, 2023
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
approved these changes
Aug 3, 2023
This was referenced Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the CWE data is that there is no error handling when we try to access weakness using this
weakness = self.db.get(self.cwe_id). For say CWE-189 which is a weakness associated with CVE-2009-3389 is not present in cwe2.database.