Add middleware to ban bytedance user agent - #1347
Merged
Merged
Conversation
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
ban_bytedance_user_agent
branch
from
November 26, 2023 21:55
a49a18e to
da95d01
Compare
pombredanne
approved these changes
Nov 26, 2023
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... just a minor nit.
| def process_request(self, request): | ||
| user_agent = request.META.get("HTTP_USER_AGENT", None) | ||
| if user_agent and "bytedance" in user_agent: | ||
| return HttpResponseForbidden("You are banned!", content_type="text/html") |
Member
There was a problem hiding this comment.
Do not provide insights to the spammer caller in this case.
Use a HttpResponseNotFound (404) instead fully empty and no message.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.