Skip to content

Add ruby gems advisory importer - #143

Merged
haikoschol merged 2 commits into
aboutcode-org:developfrom
sbs2001:develop
Jan 26, 2020
Merged

Add ruby gems advisory importer#143
haikoschol merged 2 commits into
aboutcode-org:developfrom
sbs2001:develop

Conversation

@sbs2001

@sbs2001 sbs2001 commented Jan 17, 2020

Copy link
Copy Markdown
Collaborator

Signed-off-by: sbs2001 shivam.sandbhor@gmail.com

Fixes #86

@sbs2001
sbs2001 requested a review from pombredanne January 17, 2020 18:19
@sbs2001

sbs2001 commented Jan 17, 2020

Copy link
Copy Markdown
Collaborator Author

I will soon write some tests for this importer

@sbs2001
sbs2001 force-pushed the develop branch 4 times, most recently from 048d27e to b42101a Compare January 18, 2020 16:46
@haikoschol
haikoschol self-requested a review January 20, 2020 15:41
@haikoschol

Copy link
Copy Markdown
Collaborator

@sbs2001 Thanks for this PR! A few general nitpicks (other comments inline):

  • please use snake_case instead of camelCase for variable names
  • order imports alphabetically in three blocks: standard library, third-party libraries, modules inside vulnerablecode
  • leave out parentheses in if and for if they are not necessary (i.e. not a multi-line statement)

@sbs2001

sbs2001 commented Jan 21, 2020

Copy link
Copy Markdown
Collaborator Author

@sbs2001 Thanks for this PR! A few general nitpicks (other comments inline):

* please use `snake_case` instead of `camelCase` for variable names

* order imports alphabetically in three blocks: standard library, third-party libraries, modules inside vulnerablecode

* leave out parentheses in `if` and `for` if they are not necessary (i.e. not a multi-line statement)

@haikoschol Thanks for the review! I have made the suggested changes.

Comment thread vulnerabilities/scraper/ruby.py Outdated
Comment thread vulnerabilities/scraper/ruby.py Outdated
Comment thread vulnerabilities/scraper/ruby.py Outdated
Comment thread vulnerabilities/scraper/ruby.py Outdated
Comment thread vulnerabilities/scraper/ruby.py Outdated
Comment thread vulnerabilities/scraper/ruby.py Outdated
if vulnerability_id in ids:
continue
ids.add(vulnerability_id)
else:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we will have to include vulnerabilities without a CVE ID as well, since that is meant to be one of the defining features of vulnerablecode.

Comment thread vulnerabilities/data_dump.py Outdated
Comment thread vulnerabilities/data_dump.py
Comment thread vulnerabilities/data_dump.py
Comment thread vulnerabilities/scraper/ruby.py Outdated
@sbs2001
sbs2001 force-pushed the develop branch 2 times, most recently from c8a3578 to 793be7e Compare January 25, 2020 13:01
Signed-off-by: sbs2001 <shivam.sandbhor@gmail.com>
Signed-off-by: sbs2001 <shivam.sandbhor@gmail.com>
@haikoschol
haikoschol merged commit 46e4d63 into aboutcode-org:develop Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect Rubygems advisories from https://rubysec.com/

2 participants