Update GitHub GraphQL import in vulntotal datasources - #1445
Merged
Conversation
Member
|
@poju3185 please add signoff to your commit, and you may want to go through this https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html. |
Change the method used to fetch GitHub GraphQL queries in github.py Shift from vulnerabilities.utils.fetch_github_graphql_query to fetchcode.package_versions.github_response The change avoids dependencies on Django apps in vulnerabilities.utils Signed-off-by: PoJuDeSu <spes9850401@gmail.com>
poju3185
force-pushed
the
fix-vulntotal-import
branch
from
March 21, 2024 15:33
d809940 to
23d6702
Compare
Contributor
Author
|
I've updated my commit with the sign-off. Thanks for the reminder! |
keshav-space
changed the title
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space
approved these changes
May 13, 2024
keshav-space
left a comment
keshav-space
left a comment
Member
There was a problem hiding this comment.
Thanks @poju3185, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1443
Change the usage of
vulnerabilities.utils.fetch_github_graphql_querytofetchcode.package_versions.github_responseingithub.py