Skip to content

Expose Advisory details in API - #1459

Closed
ykodwani01 wants to merge 29 commits into
aboutcode-org:mainfrom
ykodwani01:expose
Closed

Expose Advisory details in API#1459
ykodwani01 wants to merge 29 commits into
aboutcode-org:mainfrom
ykodwani01:expose

Conversation

@ykodwani01

@ykodwani01 ykodwani01 commented Apr 10, 2024

Copy link
Copy Markdown

Solves issue #1433

Signed-off-by: Yash Kodwani yashkodwani2003@gmail.com

@ykodwani01
Expose Advisory details in API
feaf0b5 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01

ykodwani01 commented Apr 10, 2024

Copy link
Copy Markdown
Author

@pombredanne @ziadhany Can you please review and let me know if any changes required

@ykodwani01 ykodwani01 mentioned this pull request Apr 10, 2024
Closed
@ziadhany

ziadhany commented Apr 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@ykodwani01 the CI ( code style is failing )

Please don't forget to run make valid and make test in the terminal to check the code style and tests before you commit.

@ykodwani01
Updated Code Style
486d803 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
ziadhany
ziadhany requested changes Apr 11, 2024
View reviewed changes

@ziadhany ziadhany left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykodwani01 Looks good! but I think the most important data we want to expose ( date_collected, created_by and url )

Comment thread vulnerabilities/api.py Outdated
@ykodwani01
Updated advisory data API response
f72c75a 
Signed-off-by: ykodwani01 <yashkodwani2003@gmail.com>
@ykodwani01

ykodwani01 commented Apr 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

@ziadhany Done with the required changes.

There is a problem with DCO, I committed one change directly from github which caused error and now Its failing the test. Can you suggest something to resolve it.

ykodwani01 and others added 22 commits April 13, 2024 01:50
@ykodwani01
Updated response of API
0b9b7f2 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated response of API
2807339 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Update test_api.py
d4354df
@ykodwani01
Updated API.py for DCO
18df6dd 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@TG1999 @ykodwani01
Prepare for release v34.0.0rc4 (#1441)
76ce9dd 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Expose Advisory details in API
4e5d8db 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated Code Style
b4d790c 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated response of API
74b24cf 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated API.py for DCO
366aa5e 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Merge branch 'expose' of https://github.com/ykodwani01/vulnerablecode …
fdef1d5 
…into expose
@ziadhany @ykodwani01
Add a test for cvss_printer (#1312)
84a494b 
Fix the cvss vector test
Resolve merge conflicts
Add exception for s.scoring_system when is not in SCORING_SYSTEMS
Add a get serverity values test
Resolve merge conflict
Change the style of cvss_printer display
Add a new filter to print cvss vectors
Change the table heading to Vertical
Add support for CVSS vectors display

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ziadhany @ykodwani01
Add support for all osv ecosystems (#926)
71ff402 
Add a GithubOSVImporter to git_importer parametrize test
Refactor OSV ecosystem mapping
Fix the test
Update univers version and pass nuget test
Resolve merge conflict
Add a test for golang
Fix test by adding cwe to expected files
Resolve merge conflict

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@shravankshenoy @ykodwani01
Add CVE support to Snyk datasource (#1405)
c3bee0d 
* Add function to generate purl from package advisory url

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add functions to generate cve url and parse the html advisory generated from the cve url

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add function to SnykDataSource class to get advisories from cve

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add tests and test data for parse_cve_advisory_html function

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add test for generate_purl function

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Remove to_dict in snyk test file where not required

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Format code using Black

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Sort imports correctly using isort

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Modify generate_purl function in snyk

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add additional tests for golang and npm

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Add non-Github Go packages to test, modify generate_purl function, improve error handling

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

* Modify generate_purl to comply with purl spec

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>

---------

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@TG1999 @ykodwani01
Add resource URL to the vulnerability and package details view in the…
e0e5276 
… API serializers (#1423)

* Add vulnerability_url in API

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Add package_url in API

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Fix tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Address review comments

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Address review comments

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Fix tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

---------

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@dependabot @ykodwani01
Bump cryptography from 42.0.0 to 42.0.4 (#1424)
baefb16 
Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.4.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@42.0.0...42.0.4)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@TG1999 @ykodwani01
Prepare for release v34.0.0rc3 (#1426)
6e20383 
* Prepare for release v34.0.0rc3

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Fix Changelog

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

---------

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@TG1999 @ykodwani01
Revert 1400-fix_dupe_changelog (#1440)
202d76c 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@TG1999 @ykodwani01
Prepare for release v34.0.0rc4 (#1441)
35f724b 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Expose Advisory details in API
590fd92 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated Code Style
e33a17c 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated response of API
c0760fb 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated API.py for DCO
c97fd5f 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Expose Advisory details in API
76829db 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated Code Style
e3e8a41 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ykodwani01
Updated response of API
7092cda 
Signed-off-by: Yash Kodwani <202101418@daiict.ac.in>
@ziadhany

ziadhany commented Apr 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@ziadhany Done with the required changes.

There is a problem with DCO, I committed one change directly from github which caused error and now Its failing the test. Can you suggest something to resolve it.

@ykodwani01 You can read these two articles :

@ykodwani01 ykodwani01 closed this by deleting the head repository Apr 13, 2024
@ykodwani01

ykodwani01 commented Apr 13, 2024

Copy link
Copy Markdown
Author

New PR is raised at #1461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziadhany ziadhany ziadhany requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ykodwani01 @ziadhany @TG1999 @shravankshenoy