Skip to content

Add basic UI template for API - #1466

Merged
pombredanne merged 1 commit into
mainfrom
api-template
Jul 16, 2024
Merged

Add basic UI template for API#1466
pombredanne merged 1 commit into
mainfrom
api-template

Conversation

@pombredanne

Copy link
Copy Markdown
Member

Borrowed from ScanCode.io

Reference: #1465
Thanks-to: Thomas Druez @tdruez

@pombredanne
pombredanne requested a review from johnmhoran April 24, 2024 13:57

@johnmhoran johnmhoran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

body {background: none;}
.navbar {background: #363636; border-top: 3px solid #3298dc;}
.navbar-inverse .navbar-brand {color: white;}
.nexb-blue

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems problematic.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does, good eye, looks like somebody started to define the CSS for .next-blue and got distracted, never finished. @pombredanne , where did this code come from?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
.booleanwidget {width: 90%;}

You need to remove the .nexb-blue line, it's not a correct syntax.

@TG1999

TG1999 commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

@pombredanne please have a look when you get a chance and merge it! Thanks!

body {background: none;}
.navbar {background: #363636; border-top: 3px solid #3298dc;}
.navbar-inverse .navbar-brand {color: white;}
.nexb-blue

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
.booleanwidget {width: 90%;}

You need to remove the .nexb-blue line, it's not a correct syntax.

Borrowed from ScanCode.io

Reference: #1465
Thanks-to: Thomas Druez @tdruez
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne

Copy link
Copy Markdown
Member Author

Changes applied. Will merge shortly! @tdruez thanks

@pombredanne

Copy link
Copy Markdown
Member Author

@tdruez all fixed. @TG1999 please review and merge

@pombredanne
pombredanne merged commit 7e2a70a into main Jul 16, 2024
@pombredanne
pombredanne deleted the api-template branch July 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants