Add support to CVSSv4 & SSVC and import the data using vulnrichment - #1484
Merged
Conversation
ziadhany
marked this pull request as ready for review
June 4, 2024 15:29
Collaborator
Author
|
@DennisClark @keshav-space @pombredanne @Hritik14 What vulnerability details would be most helpful for users to see within the CVSSv4 score? |
Member
|
The values provided in the grouping "Base Metrics" make sense here; I don't think we need more than those. |
Collaborator
Author
|
we should merge this pull request first : #1502 |
Member
Contributor
|
FYI #1502 is merged now |
Collaborator
Author
|
@TG1999 Wait, I need to add the ref type and CPES references. The code also still needs to be reviewed. |
keshav-space
requested changes
Aug 6, 2024
keshav-space
left a comment
Member
There was a problem hiding this comment.
Thanks @ziadhany, please see few nits below for your consideration and also update the branch with main.
Fix ssvc calculator bug Add support for ref cpes & fix the tests Ignore affected packages Add SSVC calculator. Add Support for SSVC. Add vulnrichment importer. Add support to CVSSv4 Signed-off-by: ziadhany <ziadhany2016@gmail.com>
keshav-space
approved these changes
Aug 13, 2024
keshav-space
left a comment
Member
There was a problem hiding this comment.
Thanks @ziadhany, Looking Good!
This was referenced Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #1473
