Skip to content

Add support to CVSSv4 & SSVC and import the data using vulnrichment - #1484

Merged
keshav-space merged 2 commits into
aboutcode-org:mainfrom
ziadhany:cvss4
Aug 13, 2024
Merged

Add support to CVSSv4 & SSVC and import the data using vulnrichment#1484
keshav-space merged 2 commits into
aboutcode-org:mainfrom
ziadhany:cvss4

Conversation

@ziadhany

@ziadhany ziadhany commented May 28, 2024

Copy link
Copy Markdown
Collaborator

issue: #1473
image

image

@ziadhany
ziadhany marked this pull request as ready for review June 4, 2024 15:29
@ziadhany

ziadhany commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator Author

@DennisClark @keshav-space @pombredanne @Hritik14

What vulnerability details would be most helpful for users to see within the CVSSv4 score?
https://www.first.org/cvss/calculator/4.0#CVSS:4.0/AV:N/AC:H/AT:P/PR:L/UI:P/VC:L/VI:H/VA:N/SC:L/SI:L/SA:N

@DennisClark

Copy link
Copy Markdown
Member

The values provided in the grouping "Base Metrics" make sense here; I don't think we need more than those.

@ziadhany ziadhany changed the title Add support to CVSSv4 Add support to CVSSv4 & SSVC and import the data using vulnrichment Jun 24, 2024
@TG1999
TG1999 requested a review from keshav-space July 9, 2024 15:26
@ziadhany

Copy link
Copy Markdown
Collaborator Author

we should merge this pull request first : #1502

@keshav-space

Copy link
Copy Markdown
Member

we should merge this pull request first : #1502

Ack @ziadhany, will hold my reviews on this until #1502 is reviewed and merged.

@TG1999

TG1999 commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

FYI #1502 is merged now

@ziadhany

Copy link
Copy Markdown
Collaborator Author

@TG1999 Wait, I need to add the ref type and CPES references. The code also still needs to be reviewed.

@keshav-space keshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, please see few nits below for your consideration and also update the branch with main.

Comment thread vulnerabilities/importers/vulnrichment.py Outdated
Comment thread vulnerabilities/importers/vulnrichment.py Outdated
Comment thread vulnerabilities/importers/vulnrichment.py
Comment thread vulnerabilities/importers/vulnrichment.py Outdated
Comment thread vulnerabilities/importers/vulnrichment.py
Fix ssvc calculator bug
Add support for ref cpes & fix the tests
Ignore affected packages
Add SSVC calculator.
Add Support for SSVC.
Add vulnrichment importer.
Add support to CVSSv4

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

@keshav-space keshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, Looking Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants