Conversation
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
tdruez
requested changes
Jul 11, 2017
| class ImpactedPackage(models.Model): | ||
| vulnerability_id = models.ForeignKey('Vulnerability') | ||
| package_id = models.ForeignKey('Package') | ||
| vulnerability_id = models.ForeignKey('Vulnerability') |
Contributor
There was a problem hiding this comment.
As you did for VulnerabilityReference.vulnerability, you should remove the _id suffix. For both fields vulnerability_id and package_id
| class ResolvedPackage(models.Model): | ||
| vulnerability_id = models.ForeignKey('Vulnerability') | ||
| package_id = models.ForeignKey('Package') | ||
| vulnerability_id = models.ForeignKey('Vulnerability') |
Contributor
There was a problem hiding this comment.
Same comment about the _id suffix.
| version = models.CharField(max_length=50, help_text="Pacakge version") | ||
|
|
||
|
|
||
| class PackageReference(models.Model): |
Contributor
There was a problem hiding this comment.
We are missing a FK to the Package model.
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
- Add tests runner in the travis config - Cleanup Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez
approved these changes
Jul 14, 2017
pombredanne
added a commit
that referenced
this pull request
Apr 2, 2025
Update .gitignore to ignore Jupyter temp files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Present: