Update VulnTotal Github Datasource - #1500
Closed
michaelehab wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Michael Ehab <michaelehab16@gmail.com>
michaelehab
force-pushed
the
vulntotal-fix-github-datasource
branch
from
July 5, 2024 11:55
9b6cbaa to
2019dd2
Compare
keshav-space
requested changes
Jul 8, 2024
keshav-space
left a comment
Member
There was a problem hiding this comment.
@michaelehab We don't need this change yet since we're still using v0.3.0 of fetchcode in VulnerableCode. https://github.com/nexB/vulnerablecode/blob/433d3a65e13d1de77d17c8ee627aca7283da0a09/requirements.txt#L116 VulnTotal and VulnerableCode share the same version of dependency. In your local installation you can use v0.3.0 of fetchcode. If you want to use the latest version of fetchcode you can make change to your import locally.
Collaborator
Author
|
@keshav-space Thank you for the clarification; I will proceed with version 0.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1499
There was an incorrect import path in the vulntotal/datasources/github.py file. The previous import statement:
it was updated to: