Skip to content

Update VulnTotal Github Datasource - #1500

Closed
michaelehab wants to merge 1 commit into
aboutcode-org:mainfrom
michaelehab:vulntotal-fix-github-datasource
Closed

Update VulnTotal Github Datasource#1500
michaelehab wants to merge 1 commit into
aboutcode-org:mainfrom
michaelehab:vulntotal-fix-github-datasource

Conversation

@michaelehab

Copy link
Copy Markdown
Collaborator

Fix #1499

There was an incorrect import path in the vulntotal/datasources/github.py file. The previous import statement:

from fetchcode.package_versions import github_response

it was updated to:

from fetchcode.utils import github_response

Signed-off-by: Michael Ehab <michaelehab16@gmail.com>
@michaelehab
michaelehab force-pushed the vulntotal-fix-github-datasource branch from 9b6cbaa to 2019dd2 Compare July 5, 2024 11:55

@keshav-space keshav-space left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelehab We don't need this change yet since we're still using v0.3.0 of fetchcode in VulnerableCode. https://github.com/nexB/vulnerablecode/blob/433d3a65e13d1de77d17c8ee627aca7283da0a09/requirements.txt#L116 VulnTotal and VulnerableCode share the same version of dependency. In your local installation you can use v0.3.0 of fetchcode. If you want to use the latest version of fetchcode you can make change to your import locally.

@michaelehab

Copy link
Copy Markdown
Collaborator Author

@keshav-space Thank you for the clarification; I will proceed with version 0.3.0.

@michaelehab michaelehab closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Import Path in VulnTotal Github datasource

2 participants