Skip to content

Rename "Fixed by vulnerabilities" column - #1519

Merged
pombredanne merged 1 commit into
mainfrom
1501-rename-fixed-vuln-column
Jul 23, 2024
Merged

Rename "Fixed by vulnerabilities" column#1519
pombredanne merged 1 commit into
mainfrom
1501-rename-fixed-vuln-column

Conversation

@johnmhoran

@johnmhoran johnmhoran commented Jul 23, 2024

Copy link
Copy Markdown
Member

Reference: #1501
Reference: #1520

@pombredanne @TG1999 -- ready for your review.

Note that when I ran make test locally, 1 test, unrelated to my update, failed:

FAILED vulnerabilities/tests/test_github_osv.py::GithubOSVImporter::test_github_osv_importer7 - TypeError: unhashable type: 'Version'

The updated column now looks like this:

image

Reference: #1501
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran johnmhoran added the ui label Jul 23, 2024
@johnmhoran
johnmhoran requested review from TG1999 and pombredanne July 23, 2024 00:28
@johnmhoran

Copy link
Copy Markdown
Member Author

@pombredanne @TG1999 Do we want a similar change from Fixed by packages to Fixed packages in the vulnerability UI search results and vulnerability details pages? The context is similar though not identical. If yes, I'll open an issue and make those changes.

image

image

@pombredanne

Copy link
Copy Markdown
Member

As discussed in the #1520 issue please use "fixing vulnerabilities" and merge!

<span
class="has-tooltip-multiline has-tooltip-black has-tooltip-arrow has-tooltip-text-left"
data-tooltip="This is the number of vulnerabilities fixed by the package.">
<span class="affected-fixed">Fixed by</span> vulnerabilities

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to also align the CSS class names with the latest and greatest

@johnmhoran

Copy link
Copy Markdown
Member Author

@pombredanne I have made the change (locally only atm) in the Packages search results page from "Fixed by vulnerabilities" (or yesterday in this PR, "Fixed vulnerabilities") to "Fixing vulnerabilities", e.g.,

image

I began to make the change you requested to the span class name for the renamed "Fixing vulnerabilities" from affected-fixed to fixing-vulnerabilities. However, checking for usage of that CSS style, I see that I used that one CSS style for all similar column names/references, i.e., it's also used in the Package search results page for the "Affected by vulnerabilities" column, and is used as well in package_details.html, vulnerabilities.html and vulnerability_details.html.

Rather than making two new classes for the package and vuln CSS column and similar references -- with the exact same settings -- for now I am making no change until you've had a chance to consider the current usage. If you'd like me to make separate names for each and rename where needed, please let me know and I'll do that.

But first.... One more related question arises from the current change. The change above is on the Packages search result page, packages.html. If you drill down by clicking one of the packages from the "Package URL" column, you come to the package details page, package_details.html, where we describe in greater detail the same set of relationships summarized in the Package search results page. Do you want any changes to the naming conventions currently used on the details page?

image

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Merging!

@pombredanne
pombredanne merged commit 98b57aa into main Jul 23, 2024
@pombredanne
pombredanne deleted the 1501-rename-fixed-vuln-column branch July 23, 2024 18:54
johnmhoran added a commit that referenced this pull request Jul 23, 2024
Reference: #1520
Related prior issue: #1501
Updates: #1519
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
michaelehab pushed a commit to michaelehab/vulnerablecode that referenced this pull request Aug 3, 2024
…e-org#1520

Reference: aboutcode-org#1520
Related prior issue: aboutcode-org#1501
Updates: aboutcode-org#1519
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants