Add importer for safetydb - #153
Conversation
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
|
@Jwomers ping! |
| if version in version_range: | ||
| affected_versions.add(version) | ||
| unaffected_versions = all_package_versions - affected_versions | ||
| if cve_id not in cves: |
There was a problem hiding this comment.
If two packages are affected by the same CVE, doesn't this check cause the second one to be skipped entirely? And didn't this issue come up before somewhere? It seems familiar...
There was a problem hiding this comment.
You are correct, I remember vaguely, that the code was violating constraints which was temporarily fixed by removing the summary. We need some concrete way to deal with this. Some pointers to duplicate(not exactly) data https://github.com/pyupio/safety-db/blob/b873cceee96c04c4e9df93d17087592e94290482/data/insecure_full.json#L247 and https://github.com/pyupio/safety-db/blob/b873cceee96c04c4e9df93d17087592e94290482/data/insecure_full.json#L256
There was a problem hiding this comment.
Let's merge it as is and refine it later.
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
| if version in version_range: | ||
| affected_versions.add(version) | ||
| unaffected_versions = all_package_versions - affected_versions | ||
| if cve_id not in cves: |
There was a problem hiding this comment.
Let's merge it as is and refine it later.
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com
This data is imported from https://github.com/pyupio/safety-db .
Fixes #91