Skip to content

Issue #151 Removed call to circl api - #159

Closed
aniketbiprojit wants to merge 4 commits into
aboutcode-org:developfrom
aniketbiprojit:develop
Closed

Issue #151 Removed call to circl api#159
aniketbiprojit wants to merge 4 commits into
aboutcode-org:developfrom
aniketbiprojit:develop

Conversation

@aniketbiprojit

Copy link
Copy Markdown

No description provided.

@haikoschol

Copy link
Copy Markdown
Collaborator

@aniket-chowdhury Thanks for this contribution. Please make sure all your commits are signed off and take into account my comment on the ticket.

@haikoschol

Copy link
Copy Markdown
Collaborator

@aniket-chowdhury are you still interested in finishing this pull request?

@aniketbiprojit

aniketbiprojit commented Mar 24, 2020

Copy link
Copy Markdown
Author

@haikoschol
Yeah. I still am.

@haikoschol

Copy link
Copy Markdown
Collaborator

@haikoschol
Yeah. I still am.

Do you need help with fixing the issues or are you just busy and haven't gotten to it yet?

@aniketbiprojit

Copy link
Copy Markdown
Author

I think it would break functionality. Could you elaborate more on the issue.

@haikoschol

Copy link
Copy Markdown
Collaborator

I think it would break functionality. Could you elaborate more on the issue.

I already did elaborate on the ticket here.

We want to remove this route completely from the application, not just the call to the other API.

The other issue with your pull request is the failing DCO check. You can find documentation on how to fix that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants