Add support for Python3.12 - #1790
Closed
kunalsz wants to merge 1 commit into
Closed
Conversation
Signed-off-by: kunalsz <kunalavengers@gmail.com>
|
Hi @kunalsz ,I think Directly adding support for python 3.12 would not do the job coz some libraries or their version are not compatible in python 3.12 as mentioned by @Dedsec0098 in one of his issue related to failing tests #1782 which means that some tests would be failing in 3.12. so you have to take a look on all of such issues which could come when workflow file runs on each pull request otherwise currently your code is cancelling the job as you can see in the image below. PYTHON_EXE should not be changed imo as I am working on python 3.13 still I use python3 while running any python command on cli. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In reference to the issue #1576
Changes made