Skip to content

Add CLI option to specify batch_size for the ImportRunner #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 1 commit into from
May 26, 2020
Merged

Add CLI option to specify batch_size for the ImportRunner #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions vulnerabilities/management/commands/import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,17 @@ def add_arguments(self, parser):
parser.add_argument('sources', nargs='*',
help='Data sources from which to import')

parser.add_argument(
'--batch_size', help='The batch size to be used for bulk inserting data')

def handle(self, *args, **options):
if options['list']:
self.list_sources()
return

if options['batch_size']:
self.batch_size = options['batch_size']

if options['all']:
self._import_data(Importer.objects.all(), options['cutoff_date'])
return
Expand Down Expand Up @@ -94,8 +100,7 @@ def import_data(self, names, cutoff_date):
def _import_data(self, importers, cutoff_date):
for importer in importers:
self.stdout.write(f'Importing data from {importer.name}')
# TODO add cmdline param for batch_size
ImportRunner(importer, 10).run(cutoff_date=cutoff_date)

batch_size = getattr(self, 'batch_size', 10)
ImportRunner(importer, batch_size).run(cutoff_date=cutoff_date)
self.stdout.write(
self.style.SUCCESS(f'Successfully imported data from {importer.name}'))