Fix Advisory.__hash__() - #189
Merged
Merged
Conversation
The hash is computed from a string, which is built by iterating over attributes of type Iterable/Sequence, such as impacted_package_urls. This change sorts those attributes before concatenating to the string, to avoid different hashes when the order of impacted_package_urls, etc differs. NB A better solution would be to avoid implementing __hash__() and use immutable collections like tuple and frozenset for the above mentioned attributes instead. See https://eng.lyft.com/hashing-and-equality-in-python-2ea8c738fb9d Signed-off-by: Haiko Schol <hs@haikoschol.com>
Collaborator
|
Works fine, tried running those tests 100 times, passed each time, feel free to merge. |
sbs2001
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash is computed from a string, which is built by iterating over attributes of type
Iterable/Sequence, such asimpacted_package_urls.This change sorts those attributes before concatenating to the string, to avoid different hashes when the order of
impacted_package_urls, etc differs.NB A better solution would be to avoid implementing
__hash__()and use immutable collections like tuple and frozenset for the above mentioned attributes instead.See https://eng.lyft.com/hashing-and-equality-in-python-2ea8c738fb9d