Refactor import runner(no change to ImpactedPackage, ResolvedPackage) - #225
Closed
sbs2001 wants to merge 3 commits into
Closed
Refactor import runner(no change to ImpactedPackage, ResolvedPackage)#225sbs2001 wants to merge 3 commits into
sbs2001 wants to merge 3 commits into
Conversation
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
refactor_import_runner
branch
from
July 10, 2020 06:02
92908dc to
d95a618
Compare
pombredanne
requested changes
Jul 13, 2020
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
I started reviewing the other PR first, but we should keep only one for your sanity. Is there any benefit you can articulate in favor or merging ImpactedPackage and ResolvedPackage in a single type?
|
|
||
| else: | ||
|
|
||
| # Check for conflicts |
Member
There was a problem hiding this comment.
I am not sure I get the code block below. Can you elaborate?
Collaborator
Author
|
Closed in Favour #219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It throws all the conflicting entries into a JSONField , so we can later ping the sources to resolve these, which is IMHO the correct way to deal with the contradictions rather than overwriting the latest entry . It also increases the performance by utilising the fact that if an entity(vulnerability or package) is created, then it's references don't exist in DB.