Scrapes data from scrapers and dump in the database by kartiksibal · Pull Request #25 · aboutcode-org/vulnerablecode

kartiksibal · 2017-07-27T10:52:03Z

Also adds description in Debian's scraper logic.

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

pombredanne · 2017-07-27T11:02:08Z

+
+    vulnerability.save()
+    vulnerability_reference.save()
+    package.save()


the save() need to be in the loop...
Otherwise you are only saving the latest item. Add some tests that show that

pombredanne · 2017-07-27T11:02:17Z

+
+
+def ubuntu_dump():
+


Add some docstring

pombredanne · 2017-07-27T11:02:56Z

+
+
+def debian_dump():
+


Add docstring

pombredanne · 2017-07-27T11:08:20Z

+    json_data = debian.json_data()
+    extracted_data = debian.extract_data(json_data)
+
+    for i, v in enumerate(extract_data):


Why do you enumerate here at all? this code makes no sense at all.

You still need to process the comment I made above ;)

@pombredanne I have removed enumerate?

* moved .save() in the loop * remove enumerate Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

* uses debian' test data to scrape * dumps data in the test DB and verifies it Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

* Changed test cases accordingly Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

pombredanne

You need to start by testing things with more assertions and ensure that all the records you expect are there. You will then see that your code is not inserting all the records

pombredanne · 2017-08-01T09:42:26Z

+
+def debian_dump(extract_data):
+    """
+    Dump data scraped from Debian' security tracker.


Save might be a better name than dump ;)

pombredanne · 2017-08-01T09:43:44Z

+        vulnerability_reference.save()
+        package.save()
+
+        return vulnerability, vulnerability_reference, package


Why do you need to return anything? Things are saved in the DB.
Also if you return here.... this will return at the first iteration. skipping all the other records.

pombredanne · 2017-08-01T09:46:13Z

+        extract_data = debian.extract_data(test_data)
+        data_dump = debian_dump(extract_data)
+
+        self.assertEqual(data_dump[0].summary, extract_data[0].get('description'))


Your tests should instead do a query in the DB. In particular you should start by asserting that the number of records you think you inserted based on the contents of tests/test_data/debian.json is correct.
Then test the values of all records

pombredanne · 2017-08-01T09:47:19Z

+        summary_create = Vulnerability.objects.create(summary="Affected package xyz")
+        summary_get = Vulnerability.objects.get(pk=summary_create.pk)
+
+        self.assertEqual(str(summary_create), "Affected package xyz")


Do not convert to a string. Instead test the attributes values here and in your other tests

@pombredanne Do you think we should be keeping test_models. Won't, test_data_dump suffice?

nope, keep these tests

and do not convert to str

@pombredanne Will update. 👍

* put expected value before test value * retrieve attr values instead of converting to strings * remove return statemetn in Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

pombredanne · 2017-08-01T21:41:27Z

+    """
+    Dump data scraped from Ubuntu's security tracker.
+    """
+    for data in extract_data:


You did not run the tests ;) where could extract_data come from?

@pombredanne It is being passed as a parameter in the method?
https://github.com/nexB/vulnerablecode/blob/data_dump/app/vulncode_app/data_dump.py#L44

I cannot see a parameter in https://github.com/nexB/vulnerablecode/pull/25/files#diff-102b650ccd1cc2cb42f5359f5101e8e1R66
def ubuntu_dump(): .... there is no args: hence I can only conclude that the code has never be run or tested ;)

pombredanne · 2017-08-01T21:43:25Z

+        extract_data = debian.extract_data(test_data)
+        data_dump = debian_dump(extract_data)
+
+        for i in range(3):


Why limit yourself to 3?

But why doing three iterations?

@pombredanne I was iterating over extract_data and incrementing pk. To match the expected data with the data we are getting. And since we have three entries, in the test data. Hence, 3

This is not a robust approach for testing. Instead use a query, this is an iterable that you can then handle. Never expect that the pk have a specific values.

@pombredanne Got it. 👍

pombredanne · 2017-08-01T21:44:03Z

+            self.assertEqual(extract_data[i].get('vulnerability_id'),
+                             VulnerabilityReference.objects.get(pk=i+1).reference_id)
+            self.assertEqual(extract_data[i].get('package_name'),
+                             Package.objects.get(pk=i+1).name)


You should do a query, not hope that the PK will be incremented linearly

Updating. 👍

pombredanne · 2017-08-01T21:44:43Z

+        data_dump = debian_dump(extract_data)
+
+        for i in range(3):
+            self.assertEqual(3, len(Vulnerability.objects.all()))


Why is the query in the range loop?

Also you should not assert on all() but instead with a filter that select what you expect there.

@pombredanne The query shouldn't be in the loop.
I'll update that. I'll factor in the second point.

@pombredanne Since, we are testing the number of entries. Isn't .all() a requirement here?

My main point was not to make that test three times in a range loop.
As far all is concerned, that is fine to count, but then use count() not all()

Gotcha 👍
I have addressed your first point.

Well there is no loop anymore. So, the root is gone.

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

tdruez

It seems that you did not run the code nor the tests.
You need to document how to run those new tests in the README and make sure those are part of the continuous integration test suite (Travis CI)

tdruez · 2017-08-02T07:04:09Z

+from scraper import debian, ubuntu
+
+
+def debian_data():


This should be in the scraper/debian.py module, for consistency with https://github.com/nexB/vulnerablecode/blob/develop/scraper/ubuntu.py#L50

@tdruez Valid point. 👍

tdruez · 2017-08-02T07:11:43Z

+    """
+    Save data scraped from Debian' security tracker.
+    """
+    for data in extract_data:


You could use ModelClass.objects.create() instead of save() for simplicity.

Also, I doubt the following objects creation works, the required fields are not properly set.

@tdruez Could you elaborate this? Are you talking in context to models.py?

For example: Vulnerability.objects.create(summary="Affected package xyz")
-> django.db.utils.IntegrityError: NOT NULL constraint failed: vulncode_app_vulnerability.cvss
Since the cvss is not a nullable field, and since you do not set a value for it, your save() cannot work

@tdruez Yes, I get your point. I'll add the updated models along the next commit.

tdruez · 2017-08-02T07:13:28Z

+        package.save()
+
+
+def ubuntu_data():


This is un-needed, just call ubuntu.scrape_cves() in the ubuntu_dump() function.

@tdruez gotcha 👍

tdruez · 2017-08-02T07:15:24Z

+class TestVulnerabilityReference(TestCase):
+    def test_vulnerability_reference(self):
+        ref_id_create = VulnerabilityReference.objects.create(reference_id="CVE-2017-8564")
+        ref_id_get = VulnerabilityReference.objects.get(pk=ref_id_create.pk)


Un-used variable.

tdruez · 2017-08-02T07:15:30Z

+class TestPackage(TestCase):
+    def test_package(self):
+        package_name_create = Package.objects.create(name="Firefox")
+        package_name_get = Package.objects.get(pk=package_name_create.pk)


Un-used variable.

tdruez · 2017-08-02T07:15:34Z

+class TestPackageReference(TestCase):
+    def test_package_reference(self):
+        platform_create = PackageReference.objects.create(platform="Maven")
+        platform_get = PackageReference.objects.get(pk=platform_create.pk)


Un-used variable.

tdruez · 2017-08-02T07:15:58Z

+class TestVulnerability(TestCase):
+    def test_vulnerability(self):
+        summary_create = Vulnerability.objects.create(summary="Affected package xyz")
+        summary_get = Vulnerability.objects.get(pk=summary_create.pk)


Un-used variable.

@tdruez test_models.py was just a trial method to test models, initially. I haven't updated it. I was under the impression that test_data_dump will suffice.

Will update this now. 👍

* removed loop, added individual asserts * removed str() * added test cases for ubuntu * updated code formatting and test cases in test_models.py Signed-off-by: kartik sibal <kartiksibal@gmail.com>

* Moved tests and scraper code in app/ Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

* added null=true in fields which can be nullable Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

* used Class.objects.create() instead of .save() * remove un-necessary ubuntu_data method Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

tdruez

Do not use null=True on CharField but blank=True instead, see https://docs.djangoproject.com/en/1.11/ref/models/fields/#null

tdruez · 2017-08-04T08:24:21Z

 class Vulnerability(models.Model):
-    summary = models.TextField(max_length=50, help_text="Summary of the vulnerability")
-    cvss = models.FloatField(max_length=50, help_text="CVSS Score")
+    summary = models.TextField(max_length=50, help_text="Summary of the vulnerability", null=True)


What's the use case for creating Vulnerability without a summary?

tdruez · 2017-08-04T08:24:49Z

-    source = models.CharField(max_length=50, help_text="Source's name eg:NVD")
-    reference_id = models.CharField(max_length=50, help_text="Reference ID, eg:CVE-ID")
-    url = models.URLField(max_length=1024, help_text="URL of Vulnerability data")
+    vulnerability = models.ForeignKey('Vulnerability', null=True)


What's the use case for creating VulnerabilityReference without a Vulnerability reference?

tdruez · 2017-08-04T08:25:21Z

-    name = models.CharField(max_length=50, help_text="Package name")
-    version = models.CharField(max_length=50, help_text="Pacakge version")
+    platform = models.CharField(max_length=50, help_text="Package platform eg:maven", null=True)
+    name = models.CharField(max_length=50, help_text="Package name", null=True)


What's the use case for creating Package without a name?

tdruez · 2017-08-04T08:25:41Z


 class PackageReference(models.Model):
-    package = models.ForeignKey('Package')
+    package = models.ForeignKey('Package', null=True)


What's the use case for creating PackageReference without a Package reference

* changed test cases accordingly * added blank=true * cleaned test_models.py Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

* an empty string will be returned instead of None Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

* added `cd app/` in before_script Signed-off-by: kartik sibal <kartiksibal@gmail.com>

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

tdruez · 2017-08-07T09:58:51Z

    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
+


Why this blank line?

tdruez · 2017-08-07T09:59:34Z

 import json
 from urllib.request import urlopen
-
+import pprint


Un-used import.

tdruez · 2017-08-07T10:01:19Z

+#  VulnerableCode is a free software code scanning tool from nexB Inc. and others.
+#  Visit https://github.com/nexB/vulnerablecode/ for support and download.
+
+from vulncode_app.models import Vulnerability


Remove un-used imports

tdruez · 2017-08-07T10:01:56Z

+    """
+    for data in extract_data:
+        vulnerability = Vulnerability.objects.create(summary=data.get('description', ''))
+        vulnerability_ref = VulnerabilityReference.objects.create(


No need to create a variable if you do not need to use the object.

tdruez · 2017-08-07T10:03:25Z

-    url = models.URLField(max_length=1024, help_text="URL of Vulnerability data")
+    source = models.CharField(max_length=50, help_text="Source's name eg:NVD", blank=True)
+    reference_id = models.CharField(max_length=50, help_text="Reference ID, eg:CVE-ID", blank=True)
+    url = models.URLField(max_length=1024, help_text="URL of Vulnerability data", null=True)


URLField is a subclass of CharField, use blank instead.

tdruez · 2017-08-07T10:03:40Z

-    version = models.CharField(max_length=50, help_text="Pacakge version")
+    platform = models.CharField(max_length=50, help_text="Package platform eg:maven", blank=True)
+    name = models.CharField(max_length=50, help_text="Package name", blank=True)
+    version = models.CharField(max_length=50, help_text="Pacakge version", blank=True)


Typo in "Pacakge"

tdruez · 2017-08-07T10:04:52Z

 class Vulnerability(models.Model):
-    summary = models.TextField(max_length=50, help_text="Summary of the vulnerability")
-    cvss = models.FloatField(max_length=50, help_text="CVSS Score")
+    summary = models.TextField(max_length=50, help_text="Summary of the vulnerability", blank=True)


Why using a TextField and not a CharField here?

tdruez · 2017-08-07T10:06:34Z

+
+from django.test import TestCase
+
+from vulncode_app.models import Vulnerability


Again, un-used import and un-used variable in that file.

* removed un-wanted creation of vars * added blank=true in urlfield * removed un-used imports Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

…to data_dump

* added doc-strings * added unique together Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

- Add missing initial migration file - Code style and naming consistency - Refine the README content - Remove un-used module and section of code Signed-off-by: Thomas Druez <tdruez@nexb.com>

Signed-off-by: Thomas Druez <tdruez@nexb.com>

pombredanne

I made some comments, most are minor and easy to address. And then we can merge this

pombredanne · 2017-08-08T10:48:38Z

 before_script:
  - pycodestyle --exclude=migrations,settings.py,lib,tests --max-line-length=100 .
+  - cd app/
+  - python3 manage.py makemigrations


Remove this. Migrations should be committed

pombredanne · 2017-08-08T10:49:07Z


 script:
  - python3.6 -m pytest -v tests/
+  - python3.6 manage.py test


We should use one or the other for running tests.... do not run tests twice

pombredanne · 2017-08-08T10:49:52Z

@@ -28,18 +29,28 @@ pycodestyle --exclude=migrations,settings.py,lib,tests --max-line-length=100 .
 cd app/
 python3.6 -m pytest -v tests/


Here too, we should only use one way to run tests. Not two

pombredanne · 2017-08-08T10:53:57Z

-    summary = models.TextField(max_length=1024,
-                               help_text="Summary of the vulnerability")
-    cvss = models.FloatField(help_text="CVSS Score")
+    summary = models.CharField(max_length=50, help_text="Summary of the vulnerability", blank=True)


Please use single quotes for all strings (unless this is a docstring or it contains a single quote itself)
This applies here and below

pombredanne · 2017-08-08T10:54:41Z

+
+        self.assertTrue(VulnerabilityReference.objects.get(reference_id="CVE-2009-2458"))
+
+        self.assertTrue(VulnerabilityReference.objects.get(reference_id="CVE-2009-2459"))


Single quotes for strings throughout.

pombredanne · 2017-08-08T10:55:33Z


+urlpatterns = [
    url(r'(?P<name>[a-z]+)/(?P<version>[0-9]+)', views.package_version, name="package_version"),
    url(r'^(?P<name>[a-z]+)', views.package, name="package"),


Single quotes

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

…to data_dump

New configure

kartiksibal added 2 commits July 27, 2017 16:14

Scrapes data from debian & ubuntu, dump it in the D#24

ea36954

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Update debian scraper and tests to include description #16

b007cb2

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

pombredanne reviewed Jul 27, 2017

View reviewed changes

Comment thread data_dump.py Outdated

def ubuntu_dump():

pombredanne Jul 27, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some docstring

pombredanne reviewed Jul 27, 2017

View reviewed changes

Comment thread data_dump.py Outdated

def debian_dump():

pombredanne Jul 27, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstring

pombredanne reviewed Jul 27, 2017

View reviewed changes

kartiksibal added 4 commits July 31, 2017 15:51

Added docstrings & formatting changes #24

7825f98

* moved .save() in the loop * remove enumerate Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Test cases for #24

49d0a2c

* uses debian' test data to scrape * dumps data in the test DB and verifies it Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Use seperate methods to scrape and dump data #24

f1a1e99

* Changed test cases accordingly Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Fixed pycodestyle error and re-worded variable names

0334beb

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

pombredanne requested changes Aug 1, 2017

View reviewed changes

kartiksibal added 2 commits August 2, 2017 01:43

Added test cases for data dump #24

9c413dc

* put expected value before test value * retrieve attr values instead of converting to strings * remove return statemetn in Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Remove pycodestyle errors #24

58e33db

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

kartiksibal force-pushed the data_dump branch from 5b8f501 to 58e33db Compare August 1, 2017 20:57

pombredanne requested changes Aug 1, 2017

View reviewed changes

pombredanne reviewed Aug 1, 2017

View reviewed changes

Moved data_dump to vulncode_app/

d3850bb

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

tdruez requested changes Aug 2, 2017

View reviewed changes

kartiksibal added 5 commits August 3, 2017 16:57

Added test cases for ubuntu, test_models.py #24

0a08cc4

* removed loop, added individual asserts * removed str() * added test cases for ubuntu * updated code formatting and test cases in test_models.py Signed-off-by: kartik sibal <kartiksibal@gmail.com>

Changed directory structure #24

4f2ffa3

* Moved tests and scraper code in app/ Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Updated models as required #24

f6cad6e

* added null=true in fields which can be nullable Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Updated data dumping code #24

cc42000

* used Class.objects.create() instead of .save() * remove un-necessary ubuntu_data method Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>

Change test cases format #24

ce03b49

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

tdruez requested changes Aug 4, 2017

View reviewed changes

kartiksibal added 4 commits August 5, 2017 00:30

Removed null=true constraint #24

d5177f7

* changed test cases accordingly * added blank=true * cleaned test_models.py Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Changed .get() to .get(,'') in scraper #24

a23d916

* an empty string will be returned instead of None Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Update travis according to changed tests directory structure

f56a019

* added `cd app/` in before_script Signed-off-by: kartik sibal <kartiksibal@gmail.com>

Update travis to run Django based tests

bd66de2

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

kartiksibal added 3 commits August 5, 2017 01:01

Added Django in requirements.txt

6bcf992

Add before_script commands to run Django tests

184266f

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Update readme with steps to scrape data and save in the DB

218fffb

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

tdruez requested changes Aug 7, 2017

View reviewed changes

kartiksibal added 5 commits August 7, 2017 23:43

Removed un-used variables #24

931d539

* removed un-wanted creation of vars * added blank=true in urlfield * removed un-used imports Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Merge branch 'data_dump' of https://github.com/nexB/vulnerablecode in…

4e4dcff

…to data_dump

Resolve merge conflicts #24

4698df0

* added doc-strings * added unique together Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Remove unique together on package #24

9906a43

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Merge branch 'develop' into data_dump

a994a23

tdruez approved these changes Aug 8, 2017

View reviewed changes

tdruez added 2 commits August 8, 2017 11:45

Clean the code before merge #25

85bd950

- Add missing initial migration file - Code style and naming consistency - Refine the README content - Remove un-used module and section of code Signed-off-by: Thomas Druez <tdruez@nexb.com>

Remove extra blank line #25

26fa349

Signed-off-by: Thomas Druez <tdruez@nexb.com>

pombredanne requested changes Aug 8, 2017

View reviewed changes

kartiksibal added 3 commits August 8, 2017 16:53

Remove makemigrations from travis #24

20ee1f9

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Convert double quotes to single quotes #24

efedb24

Signed-off-by: Kartik sibal <kartiksibal@gmail.com>

Merge branch 'data_dump' of https://github.com/nexB/vulnerablecode in…

1716de9

…to data_dump

tdruez merged commit 95f725f into develop Aug 8, 2017

tdruez deleted the data_dump branch August 8, 2017 11:55

pombredanne added a commit that referenced this pull request Apr 2, 2025

Merge pull request #25 from nexB/new-configure

a75737d

New configure


		from django.test import TestCase

		from vulncode_app.models import Vulnerability

		@@ -28,18 +29,28 @@ pycodestyle --exclude=migrations,settings.py,lib,tests --max-line-length=100 .
		cd app/
		python3.6 -m pytest -v tests/


		self.assertTrue(VulnerabilityReference.objects.get(reference_id="CVE-2009-2458"))

		self.assertTrue(VulnerabilityReference.objects.get(reference_id="CVE-2009-2459"))

Uh oh!

Uh oh!

Conversation

kartiksibal commented Jul 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pombredanne Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartiksibal Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartiksibal Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartiksibal Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartiksibal Aug 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tdruez left a comment

Choose a reason for hiding this comment

pombredanne Jul 31, 2017 •

edited

Loading

kartiksibal Jul 31, 2017 •

edited

Loading

kartiksibal Aug 2, 2017 •

edited

Loading

kartiksibal Aug 2, 2017 •

edited

Loading

kartiksibal Aug 3, 2017 •

edited

Loading

kartiksibal Aug 2, 2017 •

edited

Loading