Use packageurl version 0.9.3 and Add nginx importer - #264
Merged
Conversation
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Collaborator
Author
|
Fixes #96 |
Merged
pombredanne
approved these changes
Nov 17, 2020
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
I am merging this leave aside the few nitpickings... we should definitely add tests though!
Thanks!
| import dataclasses | ||
| import json | ||
|
|
||
| import requests |
Member
There was a problem hiding this comment.
Nit: we should sort imports. But we should also switch to using black and isort, so we can do it all at once!
| return advisories | ||
|
|
||
| def extract_fixed_pkgs(self, vuln_info): | ||
| vuln_status, version_info = vuln_info.split(": ") |
Member
There was a problem hiding this comment.
Using a .partition() is more robust as it always does a single split and always return three values making the tuple unpacking safer and more reliable. I tend to prefer it followed by a .strip() call.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com