Skip to content

Improve error handling and other misc. updates - #267

Merged
sbs2001 merged 19 commits into
mainfrom
misc-updates
Oct 20, 2020
Merged

Improve error handling and other misc. updates#267
sbs2001 merged 19 commits into
mainfrom
misc-updates

Conversation

@pombredanne

Copy link
Copy Markdown
Member

This PR improves error handling and logging when running importers.

It also does a few unrelated misc. updates:

  • disable some doctests doctrings that are not doctests
  • add a setup.py
  • move pytest.ini config to setup.cfg
  • convert and clean doc and readme to ReST

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Remove HTML format tags

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Capture errors and keep trucking
- log errors with actual trigger data and full traceback

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
pombredanne requested a review from sbs2001 October 20, 2020 09:48
Otherwise this fails to run the tests entirely.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Until we have a fix, we should disbale this.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Comment thread README.rst
@@ -0,0 +1,206 @@
VulnerableCode

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for ReSTification. Why have both README.md and README.rst ? Also they both don't look same. I don't care about alignment but please make the GIF work :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to remove the README.md.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I also need the gif to be in the repo to make things work.... this https://user-images.githubusercontent.com/28975399/89056138-2c8a8300-d379-11ea-882e-f28f38789cdc.png is not right

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is done now.

'etags': {}
},
},
# {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

>>> repo = meta.getOvalRepositoryInformation()
>>> repo.setMinimumSchemaVersion("5.9")
>>> tree.write("outfilename.xml", UTF-8", True)
>> meta = definition.getMetadata()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any preferences here, either of them is fine by me. Is there a reason you go with >> ?.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is to avoid pytest treating these as real doctests and failing since these are not meant to be passing code

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@sbs2001
sbs2001 self-requested a review October 20, 2020 10:50
@sbs2001
sbs2001 merged commit 8cb17c0 into main Oct 20, 2020
@pombredanne
pombredanne deleted the misc-updates branch October 20, 2020 11:10
@pombredanne pombredanne changed the title Improve error handling and oter misc. updates Improve error handling and other misc. updates Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants