Improve GitHub importer - #291
Merged
Merged
Conversation
pombredanne
approved these changes
Dec 11, 2020
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
This looks fine, yet having a single class at that package manager level that track the version API and the package URL type in one place
Collaborator
Author
|
@pombredanne correct me if I am wrong. The way I understood your suggestion is
|
Member
Somehow my comment was truncated! |
* The github importer used to abandon a vulnerability if the affected package had invalid name. This commit changes that behaviour to instead skip the package and import the vulnerability * This commit also enables github api to import vulnerabilities for python and rubygems packages. Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
improve_github_importer
branch
from
December 18, 2020 05:33
748103e to
5a9e2b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github importer used to abandon a vulnerability if
the affected package had invalid name. This PR changes that
behaviour to instead skip the package and import the vulnerability
This commit also enables github importer to import vulnerabilities for python
and rubygems packages. This is crucial since we can't use safetydb