added verbose plural name for PackageRelatedVulnerability model - #305
Closed
Shivam-316 wants to merge 21 commits into
Closed
added verbose plural name for PackageRelatedVulnerability model#305Shivam-316 wants to merge 21 commits into
Shivam-316 wants to merge 21 commits into
Conversation
Signed-off-by: Shivammm <coolshiv77@gmail.com>
sbs2001
requested changes
Jan 10, 2021
| @@ -0,0 +1,17 @@ | |||
| # Generated by Django 3.0.7 on 2021-01-05 17:25 | |||
Collaborator
There was a problem hiding this comment.
Could you squash this into one migration file ?
To do this you would need to delete existing migrations and generate a migration script
|
|
||
| class Meta: | ||
| unique_together = ("package", "vulnerability") | ||
| verbose_name_plural = "Package related vulnerabilities" |
Collaborator
There was a problem hiding this comment.
verbose_name_plural = "PackageRelatedVulnerabilities" would be better
Collaborator
|
Hey @Shivam-316 thanks for the PR see my review comments inline :) |
Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Tushar912 <tushar.912u@gmail.com> remove single quote at end of url Signed-off-by: Tushar912 <tushar.912u@gmail.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Shivammm <coolshiv77@gmail.com>
Bumps [lxml](https://github.com/lxml/lxml) from 4.3.3 to 4.6.2. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.3.3...lxml-4.6.2) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Shivammm <coolshiv77@gmail.com>
Signed-off-by: Shivammm <coolshiv77@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR for this project, I would really like to contribute more.