Improve docs - #316
Merged
Merged
Conversation
There are some dead 404 link and I am not sure who is behind this. Let's not use it at all for now. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
sbs2001
requested changes
Jan 29, 2021
sbs2001
left a comment
sbs2001
left a comment
Collaborator
There was a problem hiding this comment.
Thanks ! This is better, please correct the typos I've highlighted, and we're good to merge this.
Member
Author
I could not see comments about typos, may be you did not submit your review yet and the comments are still pending the full review submissian? |
sbs2001
self-requested a review
January 29, 2021 14:14
sbs2001
requested changes
Jan 29, 2021
|
|
||
| The packages are identified using Package URL `PURL | ||
| <https://github.com/package-url/purl-spec>`__ as primary identifiers rather than | ||
| CPEs. This makes packeg queries more dpscific and more accurate to answer |
Collaborator
There was a problem hiding this comment.
This line contains 2 typos
Collaborator
|
@pombredanne I don't know what happened, anyways I've commented the line with typos |
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
improve-docs
branch
from
February 13, 2021 04:50
74dbed9 to
8f77147
Compare
Collaborator
|
I commited typo fixes and merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the README documentation.