Skip to content

Collect references from github importer #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 1 commit into from
Feb 1, 2021
Merged

Collect references from github importer #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vulnerabilities/importer_yielder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
'data_source': 'GitHubAPIDataSource',
'data_source_cfg': {
'endpoint': 'https://api.github.com/graphql',
'ecosystems': ['MAVEN', 'NUGET', 'COMPOSER', 'PIP', 'RUBYGEMS']
'ecosystems': ['PIP']
}
},
{
Expand Down
32 changes: 22 additions & 10 deletions vulnerabilities/importers/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
value
}
summary
references {
url
}
}
package {
name
Expand Down Expand Up @@ -158,6 +161,24 @@ def process_name(ecosystem: str, pkg_name: str) -> Optional[Tuple[Optional[str],
if ecosystem == "NUGET" or ecosystem == "PIP" or ecosystem == "RUBYGEMS":
return None, pkg_name

@staticmethod
def extract_references(reference_data):
references = []
for ref in reference_data:
url = ref["url"]
if "GHSA-" in url.upper():
reference = Reference(
url=url,
reference_id=url.split("/")[-1]
)
else:
reference = Reference(
url=url
)
references.append(reference)

return references

def collect_packages(self, ecosystem):
packages = set()
for page in self.advisories[ecosystem]:
Expand Down Expand Up @@ -194,22 +215,13 @@ def process_response(self) -> List[Advisory]:
unaffected_purls = set()

cve_ids = set()
vuln_references = []
vuln_references = self.extract_references(adv["node"]["advisory"]["references"])
vuln_desc = adv["node"]["advisory"]["summary"]

for vuln in adv["node"]["advisory"]["identifiers"]:
if vuln["type"] == "CVE":
cve_ids.add(vuln["value"])

elif vuln["type"] == "GHSA":
ghsa = vuln["value"]
vuln_references.append(
Reference(
reference_id=ghsa,
url="https://github.com/advisories/{}".format(ghsa),
)
)

for cve_id in cve_ids:
adv_list.append(
Advisory(
Expand Down
35 changes: 30 additions & 5 deletions vulnerabilities/tests/test_data/github_api/response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
"value": "CVE-2019-0199"
}
],
"summary": "Denial of Service in Tomcat"
"summary": "Denial of Service in Tomcat",
"references":[
{
"url":"https://github.com/advisories/GHSA-qcxh-w3j9-58qr"
}
]
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -36,7 +41,12 @@
"value": "CVE-2019-0199"
}
],
"summary": "Denial of Service in Tomcat"
"summary": "Denial of Service in Tomcat",
"references":[
{
"url":"https://github.com/advisories/GHSA-qcxh-w3j9-58qr"
}
]
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -57,7 +67,12 @@
"value": "CVE-2020-1938"
}
],
"summary": "Improper Input Validation in Tomcat"
"summary": "Improper Input Validation in Tomcat",
"references":[
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -78,7 +93,12 @@
"value": "CVE-2020-1938"
}
],
"summary": "Improper Input Validation in Tomcat"
"summary": "Improper Input Validation in Tomcat",
"references":[
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -99,7 +119,12 @@
"value": "CVE-2020-1938"
}
],
"summary": "Improper Input Validation in Tomcat"
"summary": "Improper Input Validation in Tomcat",
"references":[
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand Down