Skip to content

Disable schema validation for alpine linux to fix nix test #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 1 commit into from
Feb 15, 2021
Merged

Disable schema validation for alpine linux to fix nix test #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 32 additions & 33 deletions vulnerabilities/importers/alpine_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,38 +42,38 @@
BASE_URL = "https://secdb.alpinelinux.org/"


def validate_schema(advisory_dict):
scheme = {
"distroversion": Regex(r"v\d.\d*"),
"reponame": str,
"archs": list,
"packages": [
{
"pkg": {
"name": str,
"secfixes": {
str: Or(
[
Or(
Regex(r"CVE.\d+-\d+", flags=IGNORECASE),
Regex(r"XSA-\d{3}"),
Regex(r"ZBX-\d{4}"),
Regex(r"wnpa-sec-\d{4}-\d{2}"),
Regex(r"GHSA-.{4}-.{4}-.{4}"),
)
],
"",
# FIXME: Remove the None when below issue gets fixed
# https://gitlab.alpinelinux.org/alpine/infra/alpine-secdb/-/issues/1
None,
),
},
}
}
],
object: object,
}
Schema(scheme).validate(advisory_dict)
# def validate_schema(advisory_dict):
# scheme = {
# "distroversion": Regex(r"v\d.\d*"),
# "reponame": str,
# "archs": list,
# "packages": [
# {
# "pkg": {
# "name": str,
# "secfixes": {
# str: Or(
# [
# Or(
# Regex(r"CVE.\d+-\d+", flags=IGNORECASE),
# Regex(r"XSA-\d{3}"),
# Regex(r"ZBX-\d{4}"),
# Regex(r"wnpa-sec-\d{4}-\d{2}"),
# Regex(r"GHSA-.{4}-.{4}-.{4}"),
# )
# ],
# "",
# # FIXME: Remove the None when below issue gets fixed
# # https://gitlab.alpinelinux.org/alpine/infra/alpine-secdb/-/issues/1
# None,
# ),
# },
# }
# }
# ],
# object: object,
# }
# Schema(scheme).validate(advisory_dict)


class AlpineDataSource(DataSource):
Expand Down Expand Up @@ -119,7 +119,6 @@ def _process_link(self, link) -> List[Advisory]:
if record["packages"] is None:
return advisories

validate_schema(record)
for p in record["packages"]:
advisories.extend(
self._load_advisories(
Expand Down