Resolves #380: Added severity in the view at http://127.0.0.1:8000/vulnerabilities/<vulnerability_id> - #385
Resolves #380: Added severity in the view at http://127.0.0.1:8000/vulnerabilities/<vulnerability_id>#385Pushpit07 wants to merge 18 commits into
Conversation
|
Could you post a screenshot/video/gif ? |
|
|
I've commented in #380, we want both fields of the severity. Also add signoff to your commits to pass the dco check |
…vulnerability_id> Signed-off-by: Pushpit <pushpit07@gmail.com>
BeautifulSoup would generate warnings without an explicit parser which shows up in the test results as well. It is always better to look at clean test results than one filled with unnecessary warnings. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
…ities/<vulnerability_id> Signed-off-by: Pushpit <pushpit07@gmail.com>
The earlier location http://127.0.0.1:8000/api/docs was a 404. As the urls.py suggests, the README now reflects http://127.0.0.1:8000/api/schema/swagger-ui/ After the first install, activating the venv is done prior to installing pytest, thus the system default pytest is being called. It is either required to reactive venv or run pytest via python -m. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
Here is the entire conversation: aboutcode-org#379 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
As mentioned in the previous version of README.rst, the docs should be at /api/docs. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
|
Done!
|
|
@Pushpit07 could you rebase this properly ? Also a reference can contain multiple severities, I'm wondering how that would look like on the UI side ? Ideas appreciated there :) |
|
Seems like the severities aren't being returned as a list of values. There's only one value being returned. That's why when I tried to loop over the severities, it separated the characters instead of the words
|
|
I tried to loop over a list to debug and in that case the output was as expected. So maybe there's only a single value being returned from severity
|
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
Signed-off-by: Pushpit <pushpit07@gmail.com>
The earlier location http://127.0.0.1:8000/api/docs was a 404. As the urls.py suggests, the README now reflects http://127.0.0.1:8000/api/schema/swagger-ui/ After the first install, activating the venv is done prior to installing pytest, thus the system default pytest is being called. It is either required to reactive venv or run pytest via python -m. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
Here is the entire conversation: aboutcode-org#379 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
As mentioned in the previous version of README.rst, the docs should be at /api/docs. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
BeautifulSoup would generate warnings without an explicit parser which shows up in the test results as well. It is always better to look at clean test results than one filled with unnecessary warnings. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Pushpit <pushpit07@gmail.com>
|
Rebased it properly. I've made changes to 2 files only |
|
Also, I messed up the process a little this time. Sorry for that. Won't happen in the future |
|
@Pushpit07 the rebase is messed up, I'm seeing 18 commits now. You could open a new PR on branch created off from latest main Regarding #385 (comment) you could run the nvd importer to get some real examples of multiple severity scores. |
3 participants
Added severity in the view at http://127.0.0.1:8000/vulnerabilities/<vulnerability_id> by adding the severity to the context sent by the view and referencing it in the html page