tests for update and create - #49
Closed
puneeth-chanda wants to merge 3 commits into
Closed
Conversation
Signed-off-by: puneeth2001 <puneethchanda2001@gmail.com>
singh1114
suggested changes
Jul 17, 2019
| """ | ||
| for data in extract_data: | ||
| vulnerability = Vulnerability.objects.create( | ||
| vulnerability = Vulnerability.objects.update_or_create( |
Contributor
There was a problem hiding this comment.
I think update_or_create returns more than one thing.
Contributor
There was a problem hiding this comment.
That is why this test is failing.
| VulnerabilityReference.objects.create( | ||
| vulnerability=vulnerability, | ||
| reference_id=data.get('vulnerability_id', ''), | ||
| reference_id=data.get('vulnerability_id', '') |
Contributor
There was a problem hiding this comment.
This should check if the object was created at the last stage or not.
| summary='Multiple stack-based buffer overflows in mimetex.cgi in mimeTeX')) | ||
|
|
||
| self.assertTrue(Vulnerability.objects.get( | ||
| self.assertFalse(Vulnerability.objects.get( |
Contributor
There was a problem hiding this comment.
You should not be changing the full meaning of the test.
Member
|
@singh1114 @puneeth2001 is this PR still alive? |
Member
|
@puneeth2001 Thank you for your efforts... since you did not reply, I am closing this for now. Please reopen as needed if you want to complete this. |
pombredanne
added a commit
that referenced
this pull request
Apr 2, 2025
Disable Python 3.10 tests on macOS 10.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.