Skip to content

Ignore legacy pypi package versions in github importer #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 1 commit into from
Jun 26, 2021
Merged

Ignore legacy pypi package versions in github importer #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion vulnerabilities/importers/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,69 @@
}
"""

# See https://github.com/nexB/vulnerablecode/issues/486
IGNORE_VERSIONS = {
"0.1-bulbasaur",
"0.1-charmander",
"0.3m1",
"0.3m2",
"0.3m3",
"0.3m4",
"0.3m5",
"0.4m1",
"0.4m2",
"0.4m3",
"0.4m4",
"0.4m5",
"0.5m1",
"0.5m2",
"0.5m3",
"0.5m4",
"0.5m5",
"0.6m1",
"0.6m2",
"0.6m3",
"0.6m4",
"0.6m5",
"0.6m6",
"0.7.10p1",
"0.7.11p1",
"0.7.11p2",
"0.7.11p3",
"0.8.1p1",
"0.8.3p1",
"0.8.4p1",
"0.8.4p2",
"0.8.6p1",
"0.8.7p1",
"0.9-doduo",
"0.9-eevee",
"0.9-fearow",
"0.9-gyarados",
"0.9-horsea",
"0.9-ivysaur",
"2013-01-21T20:33:09+0100",
"2013-01-23T17:11:52+0100",
"2013-02-01T20:50:46+0100",
"2013-02-02T19:59:03+0100",
"2013-02-02T20:23:17+0100",
"2013-02-08T17:40:57+0000",
"2013-03-27T16:32:26+0100",
"2013-05-09T12:47:53+0200",
"2013-05-10T17:55:56+0200",
"2013-05-14T20:16:05+0200",
"2013-06-01T10:32:51+0200",
"2013-07-19T09:11:08+0000",
"2013-08-12T21:48:56+0200",
"2013-09-11T19-27-10",
"2013-12-23T17-51-15",
"2014-01-12T15-52-10",
"2.0.1rc2-git",
"3.0.0b3-",
"3.0b6dev-r41684",
"-class.-jw.util.version.Version-",
}


class GitHubTokenError(Exception):
pass
Expand Down Expand Up @@ -265,9 +328,11 @@ def categorize_versions(
affected_versions = []
unaffected_versions = []
for version in all_versions:
if version in IGNORE_VERSIONS:
continue

if version_class(version) in version_range:
affected_versions.append(version)
else:
unaffected_versions.append(version)

return (affected_versions, unaffected_versions)