Skip to content

Add docker docs - #521

Merged
Hritik14 merged 2 commits into
aboutcode-org:mainfrom
Hritik14:docker-docs
Aug 2, 2021
Merged

Hritik14 merged 2 commits into
aboutcode-org:mainfrom
Hritik14:docker-docs

Conversation

@Hritik14

Copy link
Copy Markdown
Collaborator

This is a part of 1ab0b28
Totally my mistake to leave this file out.

Signed-off-by: Hritik Vijay hritikxx8@gmail.com

@Hritik14
Hritik14 force-pushed the docker-docs branch 5 times, most recently from 01e0e24 to 4b303e5 Compare July 28, 2021 20:50
This is a part of 1ab0b28

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Comment thread README.rst
Comment thread docs/docker_installation.rst

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! feel free to add the few suggested nits and please merge

Explicitly mention that serving VulnerableCode on a network  could be
security issue and there are several steps that may be needed to secure
such a deployment.
Further, a quick tl;dr to run with docker in readme is added for
convenience.

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
@Hritik14
Hritik14 merged commit 7d3df72 into aboutcode-org:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants