Remove hard-coded SECRET_KEY from production settings - #53
Merged
Conversation
- Fix instructions for Debian-based distros - Add instructions for running Postgres in Docker - Set DJANGO_DEV=1 in runserver call to have localhost in - ALLOWED_HOSTS closes aboutcode-org#47 Signed-off-by: Haiko Schol <hs@haikoschol.com>
This change moves the hard-coded key to vulnerablecode/dev.py for use during development (e.g. DJANGO_DEV is set). Otherwise the key is read from an environment variable with the same name. The advantage of this approach over using a gitignored file containing the secret is that it works with deployment environments that use ephemeral filesystems, such as Heroku. closes aboutcode-org#46 Signed-off-by: Haiko Schol <hs@haikoschol.com>
udaykor
approved these changes
Sep 18, 2019
udaykor
left a comment
udaykor
left a comment
Contributor
There was a problem hiding this comment.
Changes can be merged. This is a good idea to ensure dev settings are used safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes were made on top of my branch for #47. So it makes sense to review/merge #52 first.