Fixed the broken Docker Installation Link - #548
Conversation
|
Thanks for spotting this. Before anything, please add DCO to the commit. You can do it by |
Maybe it's better to have full RTD links instead of having file links? I.e. here link directly to: https://vulnerablecode.readthedocs.io/en/latest/getting-started/docker_installation.html |
|
@Hritik14, So instead of linking the file, should I link |
|
We could to do that for now but hard coding a url doesn’t feel right to me (for eg: it’s pinned on the latest version via the url) I’m writing a fresh documentation anyway so absolute url wouldn’t be a problem for the time being. |
Signed-off-by: Lawful2002 <sharshvardhan101@gmail.com>
|
@Hritik14 I have made the changes (including the DCO), can you review them? |
|
LGTM, thanks for the contribution. |
fixes #547
Fixed the broken Docker Installation link in the README.rst file under the 'Setting up VulnerableCode' section