Skip to content

Amend to_dict function for inferences - #702

Merged
TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:default-improver-follow-up-pr
Apr 21, 2022
Merged

TG1999 merged 1 commit into
aboutcode-org:mainfrom
TG1999:default-improver-follow-up-pr

Conversation

@TG1999

@TG1999 TG1999 commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

Also return an empty list instead of returning None when there is no advisory data passed in get_inferences

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
TG1999 requested review from Hritik14 and pombredanne April 19, 2022 13:31

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also return an empty list instead of returning None when there is no advisory data passed in get_inferences

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 force-pushed the default-improver-follow-up-pr branch from b24a271 to 0c360ee Compare April 21, 2022 15:17
@pombredanne pombredanne changed the title Ammend to_dict function for inferences Amend to_dict function for inferences Apr 21, 2022
@TG1999
TG1999 merged commit 6bebd6b into aboutcode-org:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants