Add namespace filter in packages api - #893
Merged
Merged
Conversation
TG1999
force-pushed
the
add_namespace_filter
branch
from
September 1, 2022 22:20
b7a140a to
36a73d0
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
add_namespace_filter
branch
from
September 1, 2022 22:21
36a73d0 to
5d2a4c9
Compare
pombredanne
approved these changes
Sep 2, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
There is a just a minor nit for your review... I will merge as-is.. but let's make sure we always order fieds in the right purl field hierarchy
| model = Package | ||
| fields = ["name", "type", "version", "subpath", "purl", "packagerelatedvulnerability__fix"] | ||
| fields = [ | ||
| "name", |
Member
There was a problem hiding this comment.
The list of fields should be ordered this way:
"purl",
"type",
"namespace",
"name",
"version",
"subpath",
"packagerelatedvulnerability__fix",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com