Override throttle rate for each endpoint - #993
Merged
Merged
Conversation
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
override_throttle
branch
from
November 3, 2022 19:57
a00bb4e to
f1b53d3
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
requested changes
Nov 4, 2022
Comment on lines
+38
to
+63
| class VulnerablePackagesAPIThrottle(StaffUserRateThrottle): | ||
| scope = "vulnerable_packages" | ||
|
|
||
|
|
||
| class BulkSearchPackagesAPIThrottle(StaffUserRateThrottle): | ||
| scope = "bulk_search_packages" | ||
|
|
||
|
|
||
| class PackagesAPIThrottle(StaffUserRateThrottle): | ||
| scope = "packages" | ||
|
|
||
|
|
||
| class VulnerabilitiesAPIThrottle(StaffUserRateThrottle): | ||
| scope = "vulnerabilities" | ||
|
|
||
|
|
||
| class AliasesAPIThrottle(StaffUserRateThrottle): | ||
| scope = "aliases" | ||
|
|
||
|
|
||
| class CPEAPIThrottle(StaffUserRateThrottle): | ||
| scope = "cpes" | ||
|
|
||
|
|
||
| class BulkSearchCPEAPIThrottle(StaffUserRateThrottle): | ||
| scope = "bulk_search_cpes" |
Contributor
There was a problem hiding this comment.
There's no better way to do this? It looks like a lot of duplication here.
Contributor
Author
There was a problem hiding this comment.
I have now used ScopeRatedThrottling, please see if it looks good
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.