Conversation
TG1999
changed the title
TG1999
changed the title
TG1999
changed the title
Contributor
Author
|
closes #981 |
…r single advisory without aliases Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
failing_test_improver
branch
from
November 11, 2022 09:09
906bba6 to
5fe61fb
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
changed the title
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
changed the title
pombredanne
requested changes
Nov 11, 2022
|
|
||
| def get_from_purl(self, purl: PackageURL): | ||
| """ | ||
| Return an existing or new Package (created if neeed) given a |
Member
There was a problem hiding this comment.
"(created if neeed) "?
Are you sure?
Contributor
Author
There was a problem hiding this comment.
You are right, we are not creating here.
| package, _ = Package.objects.get_or_create(**purl_fields) | ||
| return package | ||
|
|
||
| def get_from_purl(self, purl: PackageURL): |
Member
There was a problem hiding this comment.
I wonder if we could do better? may be for_purl?
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
marked this pull request as draft
November 21, 2022 10:15
pombredanne
requested changes
Dec 24, 2022
| return vulnerability | ||
|
|
||
|
|
||
| # def match_packages(inference, vuln): |
Member
There was a problem hiding this comment.
Please remove commented code.
Contributor
Author
There was a problem hiding this comment.
Yes this is not ready for review as of now. It's out of scope for now ( this needs model changes, which we will consider after the migration of importers is done )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #981
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com