Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPE-6530|Upgrade moonshot and cloud-moonshot-production-safety to Ruby 3.3.6 #319

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sanjipta1995
Copy link

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

@imnetworku
Copy link

Nice work. I still see one failure though...

Failures:

  1) Moonshot::Plugins::CodeDeploySetup#new should raise ArgumentError if no region arg is set
     Failure/Error: expect { subject.new('example') }.to raise_error(ArgumentError)
       expected ArgumentError but nothing was raised
     # ./spec/moonshot/plugins/code_deploy_setup_spec.rb:7:in `block (3 levels) in <top (required)>'

Finished in 3.43 seconds (files took 0.3082 seconds to load)
125 examples, 1 failure

Failed examples:

rspec ./spec/moonshot/plugins/code_deploy_setup_spec.rb:5 # Moonshot::Plugins::CodeDeploySetup#new should raise ArgumentError if no region arg is set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants