Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use new atomic depositor in adapters #1852

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

bmzig
Copy link
Contributor

@bmzig bmzig commented Oct 7, 2024

This updates the adapters to use the new atomic depositor.

@bmzig bmzig added the do not merge Don't merge until label is removed label Oct 7, 2024
pxrl
pxrl previously approved these changes Oct 25, 2024
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmzig LGTM. Have you tested each of these deposit routes?

@pxrl
Copy link
Contributor

pxrl commented Oct 25, 2024

One additional thought - it'd be nice with a script to ease the process of adding new chains.

Base automatically changed from npai/atomic-weth-depositor to master October 25, 2024 15:59
An error occurred while trying to automatically change base from npai/atomic-weth-depositor to master October 25, 2024 15:59
@bmzig
Copy link
Contributor Author

bmzig commented Dec 25, 2024

This has been redeployed to 0x1046996e21d4492Dfd97CF255be883587Db3c9dC. I've configured and tested:
Optimism: init recv
World Chain: init recv
Redstone: init recv
Lisk: init recv
Base: init recv
Blast: init recv
Mode: init recv
Zora: init recv
Linea: init recv
Polygon: init recv
ZkSync: init recv

I can confirm that transfer tracking works as expected for all of these deposits.

Ink and Superseed are also configured but untested.

@bmzig bmzig removed the do not merge Don't merge until label is removed label Dec 25, 2024
@bmzig bmzig requested review from james-a-morris and pxrl December 25, 2024 22:40
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm - have we fully tested these routes locally?

@bmzig
Copy link
Contributor Author

bmzig commented Jan 6, 2025

to confirm - have we fully tested these routes locally?

That is correct.

@bmzig
Copy link
Contributor Author

bmzig commented Jan 6, 2025

Now tested for Ink (init and recv).

nicholaspai
nicholaspai previously approved these changes Jan 9, 2025
@bmzig
Copy link
Contributor Author

bmzig commented Jan 10, 2025

Reployed at https://etherscan.io/address/0x64668fbd18b967b46dd22dc8675134d91efedd8d so that we could accommodate custom gas token bridges. It has been configured and tested for the following 12 chains:
Optimism: init recv
World Chain: init recv
Redstone: init recv
Lisk: init recv
Base: init recv
Blast: init recv
Mode: init recv
Zora: init recv
Linea: init recv
Polygon: init recv
ZkSync: init recv
Ink init recv

I can confirm that transfer tracking works as expected for all of these deposits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are some of these artifacts from multiple deployments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The a4... one is the most up-to-date one, so I'll keep that one. The other two are gone. 8e85670

@bmzig
Copy link
Contributor Author

bmzig commented Jan 16, 2025

Soneium init and recv

@bmzig bmzig requested a review from james-a-morris January 16, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants