-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: use new atomic depositor in adapters #1852
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: nicholaspai <[email protected]>
Signed-off-by: bennett <[email protected]>
This reverts commit 13168f9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmzig LGTM. Have you tested each of these deposit routes?
One additional thought - it'd be nice with a script to ease the process of adding new chains. |
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
This has been redeployed to 0x1046996e21d4492Dfd97CF255be883587Db3c9dC. I've configured and tested: I can confirm that transfer tracking works as expected for all of these deposits. Ink and Superseed are also configured but untested. |
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to confirm - have we fully tested these routes locally?
That is correct. |
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
…tomicWethAdapters
Signed-off-by: bennett <[email protected]>
Reployed at https://etherscan.io/address/0x64668fbd18b967b46dd22dc8675134d91efedd8d so that we could accommodate custom gas token bridges. It has been configured and tested for the following 12 chains: I can confirm that transfer tracking works as expected for all of these deposits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are some of these artifacts from multiple deployments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. The a4... one is the most up-to-date one, so I'll keep that one. The other two are gone. 8e85670
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
This updates the adapters to use the new atomic depositor.