Basic GeoJSON output #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make simplification explicit step * Remove writeBox functions * Add explicit geojson and wkt conversion functions
|
Thanks Axel, looks good. As discussed in person, I would prefer an additional option to enable the GeoJSON dump, with the default being that GeoJSON dump is disabled (to preserve the current behavior). It would be nice if we could also have WKB (binary WKT, "well-known binary") as a serialization format and our "own" compressed binary format (for loading qlever-petrimaps). This "NSWKB" (not so well-known binary) format could be based on 32bit floats (instead of 64bit as the standard requires) and stored as a base64 string to safe space. This would completely remove the need for WKT parsing in qlever-petrimaps. |
|
Another suggestion for the format name would be "LKB" (little-known binary), this would keep the name smaller 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic GeoJSON output to osm2rdf for the
hasGeometrypredicate. Other predicates still return only WKT.