Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a runtime parameter for lazy result max cache size #1638

Merged

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Nov 24, 2024

Introduce a runtime parameter to control up until which memory size lazy results will tried to be cached.
Making this larger increases runtime and memory overhead, because each lazy result in an execution tree has to be copied until it is larger than the parameter.

@RobinTF RobinTF requested a review from joka921 November 24, 2024 23:46
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (44e2ba8) to head (2556f91).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         381      381           
  Lines       36792    36785    -7     
  Branches     4170     4169    -1     
=======================================
- Hits        32955    32950    -5     
+ Misses       2525     2521    -4     
- Partials     1312     1314    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very nice,
A few minor comments, and we will play around with this on larger knowledge graphs, to see the effects.

src/global/RuntimeParameters.h Outdated Show resolved Hide resolved
src/engine/Operation.cpp Outdated Show resolved Hide resolved
test/OperationTest.cpp Outdated Show resolved Hide resolved
src/engine/Operation.cpp Outdated Show resolved Hide resolved
@sparql-conformance
Copy link

Copy link

sonarqubecloud bot commented Dec 3, 2024

@joka921 joka921 changed the title Introduce extra runtime parameter for lazy result max cache size Introduce a runtime parameter for lazy result max cache size Dec 4, 2024
@joka921 joka921 merged commit f215842 into ad-freiburg:master Dec 4, 2024
23 checks passed
@RobinTF RobinTF deleted the use-separate-parameter-for-lazy-caching branch December 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants