-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a runtime parameter for lazy result max cache size #1638
Introduce a runtime parameter for lazy result max cache size #1638
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 381 381
Lines 36792 36785 -7
Branches 4170 4169 -1
=======================================
- Hits 32955 32950 -5
+ Misses 2525 2521 -4
- Partials 1312 1314 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks very nice,
A few minor comments, and we will play around with this on larger knowledge graphs, to see the effects.
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
Introduce a runtime parameter to control up until which memory size lazy results will tried to be cached.
Making this larger increases runtime and memory overhead, because each lazy result in an execution tree has to be copied until it is larger than the parameter.