Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make query planning of index scans fast again #1674

Merged

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 12, 2024

Since #1619, the size estimate for an index scan always involved one or several copies of the block metadata, which incurred a significant query planning cost for most queries. Now, such a copy is only made for an index scan followed by a FILTER and only the metadata of those blocks is copied, which remain after the FILTER (in which case the two operations are expensive anyway).

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (0400f90) to head (e48f215).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1674   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files         383      383           
  Lines       36942    36941    -1     
  Branches     4174     4174           
=======================================
+ Hits        33129    33131    +2     
+ Misses       2512     2511    -1     
+ Partials     1301     1299    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes + tested it on Wikidata + does the job, thanks a lot!

@hannahbast hannahbast changed the title Make the query planning of Index scans fast again. Make query planning of index scans fast again Dec 12, 2024
@hannahbast hannahbast merged commit 4a15994 into ad-freiburg:master Dec 12, 2024
23 checks passed
@joka921 joka921 deleted the faster-query-planning-prefilter branch December 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants