Skip to content

fix tests with dateparser 1.4.2 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adbar merged 2 commits into from
Sep 10, 2026
Merged

fix tests with dateparser 1.4.2 #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c70c4
fix tests with dateparser 1.4.2
dotlambda Aug 9, 2026
356563f
update dateparser
adbar Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ The additional library ``cchardet`` (or its fork ``faust-cchardet``) can be inst

You can also install or update the packages separately, *htmldate* will detect which ones are present on your system and opt for the best available combination.

The ``dateparser`` package is noticeably slower in its latest versions, version ``1.1.2`` is recommended for speed.

*For infos on dependency management of Python packages see* `this discussion thread <https://stackoverflow.com/questions/41573587/what-is-the-difference-between-venv-pyvenv-pyenv-virtualenv-virtualenvwrappe>`_.


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ classifiers = [
]
dependencies = [
"charset_normalizer >= 3.4.0",
"dateparser >= 1.1.2", # 1.1.3+ slower
"dateparser >= 1.4.2",
"lxml >= 5.3.0",
"python-dateutil >= 2.9.0.post0",
"urllib3 >= 1.26, < 3",
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,7 +1333,7 @@ def test_external_date_parser():
# https://github.com/scrapinghub/dateparser/issues/406
assert (
external_date_parser("2018-04-12 17:20:03.12345678999a", OUTPUTFORMAT)
== "2018-12-04"
== "2018-04-12"
)
# https://github.com/scrapinghub/dateparser/issues/685
assert external_date_parser("12345678912 days", OUTPUTFORMAT) is None
Expand Down
Loading