Skip to content

fix(loc): use Smartling file status instead of job percentComplete - #809

Open
markdaugherty wants to merge 6 commits into
smartling-per-job-project-selectionfrom
fix/smartling-file-status-progress
Open

fix(loc): use Smartling file status instead of job percentComplete#809
markdaugherty wants to merge 6 commits into
smartling-per-job-project-selectionfrom
fix/smartling-file-status-progress

Conversation

@markdaugherty

@markdaugherty markdaugherty commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

  • Stacked on feat(loc): add per-job Smartling project, auto-authorize, and workflow selection #766.

  • Poll file/status per file instead of the job /progress endpoint.

  • Compute progress with Smartling's formula: floored, and unauthorized strings keep a locale below 100%.

  • Mark a locale translated only when every file is at 100%; otherwise show the lowest per-file progress.

  • Remove the progress: null → 100% rule. A locale missing from the response counts as 0%.

  • Report an error when a status request fails or Smartling reports zero strings for a file.

  • Re-check terminal status after status requests return so a completed or cancelled language is not overwritten.

  • Skip overlapping status polls in handleGetStatus.

  • Note: file/status is per project and fileUri, not per job, so jobs that reuse a fileUri share counts.

  • Add tests for the formula, unauthorized strings, multi-file progress, the mid-flight completion case, and the busy guard.

  • Persist the processUid from a pending locale cancel and resolve it through the job process endpoint in getStatusAll.

  • Treat a cancel that returns 202 without a processUid as an error.

  • Remove the file-status inference that marked unlisted locales as cancelled.

  • Add tests for completed, failed, in-progress, and missing-processUid cancels.

@aem-code-sync

aem-code-sync Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from 0960b80 to ba15cbc Compare October 6, 2026 18:59
@markdaugherty
markdaugherty changed the base branch from main to smartling-per-job-project-selection October 6, 2026 18:59
@markdaugherty
markdaugherty added this pull request to stack #830 October 6, 2026 19:00
@markdaugherty
markdaugherty marked this pull request as ready for review October 6, 2026 19:00
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from ba15cbc to c559ee2 Compare October 6, 2026 19:29
@markdaugherty
markdaugherty requested a review from mhaack October 6, 2026 19:32
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from c559ee2 to 12de5ca Compare October 6, 2026 22:07
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from 12de5ca to 6038e5e Compare October 12, 2026 16:27
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from 6038e5e to 59cb678 Compare October 19, 2026 23:17
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from 59cb678 to d63ad54 Compare October 20, 2026 13:28
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from d63ad54 to a4a4256 Compare October 20, 2026 21:24
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from a4a4256 to b2188c6 Compare October 21, 2026 20:46
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from b2188c6 to 2b5dfdf Compare October 22, 2026 02:25
@mhaack
mhaack force-pushed the fix/smartling-file-status-progress branch from 2b5dfdf to b512aa4 Compare October 22, 2026 18:32
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from b512aa4 to bae69e4 Compare October 22, 2026 20:55
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch 2 times, most recently from 1252de4 to d212898 Compare October 26, 2026 13:57
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from d212898 to a79e08b Compare October 26, 2026 18:06
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from a79e08b to ec0405c Compare October 27, 2026 14:19
mhaack
mhaack reviewed Oct 27, 2026
View reviewed changes
Comment thread nx/blocks/loc/connectors/smartling/index.js Outdated
delete lang.translation.cancelPending;
lang.translation.translated = 0;
lang.translation.status = 'cancelled';
continue; // eslint-disable-line no-continue

@mhaack mhaack Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project-level file statuses can persist after a locale is removed from this job, so this can leave cancellation pending indefinitely or mark a cancelled language as translated and auto-save it. Please reconcile pending cancellations against job membership or the cancellation process endpoint instead.

@markdaugherty markdaugherty Oct 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4f763fa

Mark Daugherty and others added 5 commits October 27, 2026 14:58
Mark Daugherty
fix(loc): use Smartling file status instead of job percentComplete
b1f8eea 
Job-scoped percentComplete ignores unauthorized strings and reports null
for locales it has no content for, so a locale could be marked translated
and downloaded while strings were still untranslated. Poll per-file
file/status and compute progress with Smartling's documented formula.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts:
#	nx/blocks/loc/connectors/smartling/index.js
#	test/loc/connectors/smartling/index.test.js
Mark Daugherty
chore(loc): clean up jobUid persistence comment in smartling connector
0542711 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mark Daugherty
fix(loc): guard smartling status polling against concurrent saves
a23deba 
Re-check terminal status after file status requests return so a language
that completed mid-flight is not overwritten, and skip overlapping status
polls in handleGetStatus.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

# Conflicts:
#	nx/blocks/loc/views/translate/translate.js
Mark Daugherty
test(loc): cover the translate status busy guard
c14d99e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mark Daugherty
fix(loc): clear pending cancel in smartling status check
a3ad973 
A language with a pending cancel whose locale no file lists any more is
now marked cancelled. Replaces two stale tests that mocked the old job
progress endpoint.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@markdaugherty
markdaugherty force-pushed the fix/smartling-file-status-progress branch from ec0405c to a3ad973 Compare October 27, 2026 19:58
Mark Daugherty
fix(loc): resolve smartling pending cancels via process endpoint
4f763fa 
Project-level file status can persist after a locale is removed, so a
pending cancel could stay pending forever or be marked translated. Persist
the cancel processUid and resolve pending cancels through the job process
endpoint instead. A 202 without a processUid is now treated as an error.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
fix/smartling-file-status-progress — 4f763fa9 Deployed Oct 27, 2026 by aem-code-sync[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaack mhaack mhaack left review comments
@shsteimer shsteimer Awaiting requested review from shsteimer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markdaugherty @mhaack