feat: Package generation for JCR pages #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ManasMaji
commented
Dec 18, 2024
ManasMaji
commented
- Added logic for creating content package using the JCR pages that were generated
bhellema
reviewed
Dec 18, 2024
| // Regex for inline images & reference-style images | ||
| // 1. inline images:  | ||
| // 2. reference-style images: ![Alt text][ReferenceLabel] | ||
| const imageRegex = /!\[([^\]]*)]\(([^) "]+)(?: *"([^"]*)")?\)|!\[([^\]]*)]\[([^\]]+)]/g; |
There was a problem hiding this comment.
I wonder if we need to support in richtext.
bhellema
approved these changes
Dec 18, 2024
| @@ -0,0 +1,79 @@ | |||
| /* | |||
There was a problem hiding this comment.
The indentation in this file seems to be 4 spaces vs the other files of 2. Actually there's a number of files that have 4 vs 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.