Fix NullPointer Exception (#9)

Fixes #8
aensley · Jul 31, 2019 · d29a81f · d29a81f
1 parent d9206a6
commit d29a81f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/dist/sonar-teams-notifier-1.1.1.jar → dist/sonar-teams-notifier-1.1.2.jar b/dist/sonar-teams-notifier-1.1.1.jar → dist/sonar-teams-notifier-1.1.2.jar
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
   <groupId>com.andrewensley.sonarteamsnotifier</groupId>
   <artifactId>sonar-teams-notifier</artifactId>
-  <version>1.1.1</version>
+  <version>1.1.2</version>
 
   <packaging>sonar-plugin</packaging>
 

diff --git a/src/main/java/com/andrewensley/sonarteamsnotifier/extension/TeamsHttpClient.java b/src/main/java/com/andrewensley/sonarteamsnotifier/extension/TeamsHttpClient.java
@@ -287,12 +287,14 @@ private int getPort() {
    */
   private String getPath() {
     String tempPath = hook.getPath();
-    if (!hook.getQuery().isEmpty()) {
-      tempPath += "?" + hook.getQuery();
+    String query = hook.getQuery();
+    if (query != null && !query.isEmpty()) {
+      tempPath += "?" + query;
     }
 
-    if (!hook.getRef().isEmpty()) {
-      tempPath += "#" + hook.getRef();
+    String ref = hook.getRef();
+    if (ref != null && !ref.isEmpty()) {
+      tempPath += "#" + ref;
     }
 
     return tempPath;

diff --git a/...main/java/com/andrewensley/sonarteamsnotifier/extension/TeamsPostProjectAnalysisTask.java b/...main/java/com/andrewensley/sonarteamsnotifier/extension/TeamsPostProjectAnalysisTask.java
@@ -67,7 +67,7 @@ public void finished(final ProjectAnalysis analysis) {
         return;
       }
 
-      LOG.info("Teams notification URLL " + hook);
+      LOG.info("Teams notification URL: " + hook);
       LOG.info("Teams notification message: " + analysis.toString());
 
       Payload payload = PayloadBuilder.of(analysis)