Skip to content

Include py310 into code coverage report - #7639

Open
agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:chore/fix-project-coverage
Open

agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:chore/fix-project-coverage

Conversation

@agoscinski

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 44693a2b-db70-470f-8a4c-061efcb4ce32

📥 Commits

Reviewing files that changed from the base of the PR and between 0351256 and c0912da.

📒 Files selected for processing (2)
  • .github/workflows/ci-code.yml
  • codecov.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The CI matrix now collects and uploads coverage for every Python and broker combination. Coverage report and artifact names include matrix versions. Codecov notifications now wait for five builds.

Changes

Coverage reporting

Layer / File(s) Summary
Matrix coverage collection and upload
.github/workflows/ci-code.yml
The test command enables coverage for every matrix job. Coverage reports and artifacts are uploaded for every job, with Python and broker versions in the names.
Codecov notification threshold
codecov.yml
Codecov waits for five builds before sending notifications instead of one.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c0912

The notification threshold matches the expanded coverage upload cohort, with no confirmed merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was added, so the change rationale and scope are not documented. Add a brief description that explains the coverage changes across Python versions and the Codecov notification change.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title describes a real part of the change by mentioning Python 3.10 coverage, but the pull request updates coverage reporting for all Python versions.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@agoscinski
agoscinski force-pushed the chore/fix-project-coverage branch from c0912da to 7b45537 Compare September 15, 2026 13:25
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.80%. Comparing base (0351256) to head (7b45537).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7639      +/-   ##
==========================================
+ Coverage   81.75%   81.80%   +0.06%     
==========================================
  Files         633      633              
  Lines       52731    52731              
==========================================
+ Hits        43104    43133      +29     
+ Misses       9627     9598      -29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agoscinski agoscinski changed the title Include all python versions into code coverage report Include py310 into code coverage report Sep 15, 2026
Comment thread codecov.yml
codecov:
notify:
after_n_builds: 1
after_n_builds: 5 # 4x tests (2 python x 2 brokers) + 1x test-pytest-fixtures

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see argument for 1, now this number has to be updated each time we add something to codecov. With 1 we dont need to care, but with 1 it was also a bit flaky. One wasn't sure if it already updated or one has to still wait.

# Do not instrument the generated script: coverage's subprocess patch otherwise traces its large write loop.
retcode, stdout, stderr = transport.exec_command_wait(
f'env -u COVERAGE_PROCESS_CONFIG -u COVERAGE_PROCESS_START python3 {script_fname}', workdir=directory_path
)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to investigate this more, I feel like we don't want to do this to be here set manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant