Include py310 into code coverage report - #7639
agoscinski wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe CI matrix now collects and uploads coverage for every Python and broker combination. Coverage report and artifact names include matrix versions. Codecov notifications now wait for five builds. ChangesCoverage reporting
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The notification threshold matches the expanded coverage upload cohort, with no confirmed merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c0912da to
7b45537
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7639 +/- ##
==========================================
+ Coverage 81.75% 81.80% +0.06%
==========================================
Files 633 633
Lines 52731 52731
==========================================
+ Hits 43104 43133 +29
+ Misses 9627 9598 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| codecov: | ||
| notify: | ||
| after_n_builds: 1 | ||
| after_n_builds: 5 # 4x tests (2 python x 2 brokers) + 1x test-pytest-fixtures |
There was a problem hiding this comment.
I can see argument for 1, now this number has to be updated each time we add something to codecov. With 1 we dont need to care, but with 1 it was also a bit flaky. One wasn't sure if it already updated or one has to still wait.
| # Do not instrument the generated script: coverage's subprocess patch otherwise traces its large write loop. | ||
| retcode, stdout, stderr = transport.exec_command_wait( | ||
| f'env -u COVERAGE_PROCESS_CONFIG -u COVERAGE_PROCESS_START python3 {script_fname}', workdir=directory_path | ||
| ) |
There was a problem hiding this comment.
Need to investigate this more, I feel like we don't want to do this to be here set manually
No description provided.