Conversation
Allow cleaning the remote work directories of all calcjobs that are descendants of specified workchains via a new `-w/--workchains` option. Each workchain is identified by its PK or UUID and its full `called_descendants` subtree is traversed; only `CalcJobNode` instances are selected. The option can be given multiple times. The selection is unioned with any explicit calcjob arguments. If a workchain list is provided but resolves to no calcjob descendants, the command aborts with a clear message rather than falling through to the unfiltered query. Addresses aiidateam#4693.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: aiidateam/aiida-core/.coderabbit.yaml Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ChangesWorkchain cleanup
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant CLI
participant WorkChain
participant CalcJobRemotePaths
CLI->>WorkChain: resolve selected workchains
WorkChain-->>CLI: return CalcJob descendant PKs
CLI->>CalcJobRemotePaths: request remote paths for selected PKs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds a
-w/--workchainsoption toverdi calcjob cleanworkdirso that the remote work directories of everyCalcJobNodein a workchain'scalled_descendantssubtree can be cleaned in one command, without having to enumerate the individual calcjob PKs.Example
Behaviour
ProcessParamType(accepts PK or UUID) and restricted toWorkChainNodesubclasses.multiple=True; results from every workchain are unioned with any explicit calcjob arguments.CalcJobNodedescendants, the command aborts with an explicit message rather than falling through to the unfiltered query (which would otherwise match every calcjob in the profile).Addresses #4693.