-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kwargs in aiohttp.client.request #10300
Conversation
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #10300 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10300 +/- ##
==========================================
- Coverage 98.78% 98.77% -0.01%
==========================================
Files 122 122
Lines 37029 37038 +9
Branches 2041 2041
==========================================
+ Hits 36579 36585 +6
- Misses 311 314 +3
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sam Bull <[email protected]>
That's a bit weird. It's lost coverage of some exception handling in the autobahn test... |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 3d06cc1 on top of patchback/backports/3.11/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 Backporting merged PR #10300 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 3d06cc1 on top of patchback/backports/3.12/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 Backporting merged PR #10300 into master
🤖 @patchback |
Thanks for that, if you could handle the backports as well, that'd be great. |
I just realized I forgot to push the documentation updates to this pr. 😢 Opened a new pr to compelete the work. |
(cherry picked from commit 3d06cc1)
(cherry picked from commit 3d06cc1)
(cherry picked from commit 3d06cc1)
What do these changes do?
Make
aiohttp.client.request
use kwargs to let it accept parameters defined in_RequestOptions
likessl
.Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #10077
Checklist
CONTRIBUTORS.txt
CHANGES/
folder