Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiohttp-openmetrics to list of third party aiohttp-related python… #10304

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jelmer
Copy link
Contributor

@jelmer jelmer commented Jan 6, 2025

… modules

What do these changes do?

Add aiohttp-openmetrics to the list of third party aiohttp-related python modules.

Are there changes in behavior for the user?

N/A

Is it a substantial burden for the maintainers to support this?

No

Related issue number

N/A

Checklist

  • I think the code is well written (N/A)
  • Unit tests for the changes exist (N/A)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt (N/A)
  • Add a new news fragment into the CHANGES/ folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 6, 2025
@jelmer jelmer force-pushed the aiohttp-openmetrics branch from c664628 to 321e8ba Compare January 6, 2025 23:54
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #10304 will not alter performance

Comparing jelmer:aiohttp-openmetrics (321e8ba) with master (3d06cc1)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (3d06cc1) to head (321e8ba).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10304   +/-   ##
=======================================
  Coverage   98.77%   98.78%           
=======================================
  Files         122      122           
  Lines       37038    37038           
  Branches     2041     2041           
=======================================
+ Hits        36585    36588    +3     
+ Misses        314      311    -3     
  Partials      139      139           
Flag Coverage Δ
CI-GHA 98.67% <ø> (+<0.01%) ⬆️
OS-Linux 98.35% <ø> (+<0.01%) ⬆️
OS-Windows 96.26% <ø> (+<0.01%) ⬆️
OS-macOS 97.46% <ø> (ø)
Py-3.10.11 97.36% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.74% <ø> (-0.19%) ⬇️
Py-3.10.16 97.23% <ø> (?)
Py-3.11.11 98.01% <ø> (ø)
Py-3.11.9 97.43% <ø> (ø)
Py-3.12.8 98.44% <ø> (ø)
Py-3.13.1 98.43% <ø> (ø)
Py-3.9.13 97.25% <ø> (+<0.01%) ⬆️
Py-3.9.20 97.12% <ø> (-0.69%) ⬇️
Py-3.9.21 97.61% <ø> (?)
Py-pypy7.3.16 97.39% <ø> (-0.01%) ⬇️
VM-macos 97.46% <ø> (ø)
VM-ubuntu 98.35% <ø> (+<0.01%) ⬆️
VM-windows 96.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Jan 7, 2025
@Dreamsorcerer Dreamsorcerer merged commit b6ffb1d into aio-libs:master Jan 7, 2025
41 of 42 checks passed
Copy link
Contributor

patchback bot commented Jan 7, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/b6ffb1d1a3b710c600f06c9d21cf62f75d324767/pr-10304

Backported as #10305

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Jan 7, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/b6ffb1d1a3b710c600f06c9d21cf62f75d324767/pr-10304

Backported as #10306

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 7, 2025
Dreamsorcerer pushed a commit that referenced this pull request Jan 7, 2025
…f third party aiohttp-related python… (#10306)

**This is a backport of PR #10304 as merged into master
(b6ffb1d).**

Co-authored-by: Jelmer Vernooij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants